Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2564293002: Revert of Enable RL by default (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org, gambard, jif, stkhapugin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable RL by default (patchset #6 id:100001 of https://codereview.chromium.org/2562643003/ ) Reason for revert: Speculative revert as I think this CL broke the downstream autoroller. It is a bit hard to debug as the autoroller was unable to land some CL as the downstream tree was closed, but the last successful roll would have happened at 39e086ae3 [1], and the first failing roll is at a229e828a [2]. This CL is the only one having an impact on the iOS build, so I think it is causing the failures: $ git log --oneline 39e086ae3...a229e828a a229e828a692 Strength-reduce the "scale-factor changed" condition in LayoutSVGRoot d1693364766c Update V8 to version 5.7.202. 7cfbed3def4f Enable RL by default 314c528dc177 Revert of Improve EAT_STREAM_PARAMETERS for Windows x86 (patchset #10 id:240001 of https://codereview.chromium.org/2559323007/ ) [1]: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/trunk-autoroller/builds/6861 [2]: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/trunk-autoroller/builds/6862 Original issue's description: > Enable RL by default > > BUG=577659 > > Review-Url: https://codereview.chromium.org/2562643003 TBR=noyau@chromium.org,mardini@chromium.org,olivierrobin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=577659 NOTRY=true Committed: https://crrev.com/0d282c20583109e145853640de2e3e564b15a691 Cr-Commit-Position: refs/heads/master@{#437799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M components/reading_list/core/BUILD.gn View 2 chunks +0 lines, -10 lines 0 comments Download
D components/reading_list/core/reading_list.gni View 1 chunk +0 lines, -9 lines 0 comments Download
M components/reading_list/core/reading_list_switches.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/reading_list/core/reading_list_switches.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M ios/chrome/browser/about_flags.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
sdefresne
Created Revert of Enable RL by default
4 years ago (2016-12-11 18:01:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564293002/1
4 years ago (2016-12-11 18:01:20 UTC) #3
sdefresne
I did investigate the failures, and there are real bug in the Reading List code ...
4 years ago (2016-12-11 18:26:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/196713)
4 years ago (2016-12-11 19:21:56 UTC) #6
Olivier
lgtm
4 years ago (2016-12-11 19:22:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564293002/1
4 years ago (2016-12-11 19:23:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564293002/1
4 years ago (2016-12-11 19:29:56 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-11 19:33:44 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-12 15:09:57 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d282c20583109e145853640de2e3e564b15a691
Cr-Commit-Position: refs/heads/master@{#437799}

Powered by Google App Engine
This is Rietveld 408576698