Issue 2564263002: Merge 2924: Fix not to double count the widths of hyphens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2564263002: Merge 2924: Fix not to double count the widths of hyphens (Closed)

Created:
4 years ago by kojii

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Merge 2924: Fix not to double count the widths of hyphens The widths of hyphens are added to BidiRun in LayoutBlockFlow, and should not be included in WordMeasurement. BUG=671129 Review-Url: https://codereview.chromium.org/2548333004 Cr-Commit-Position: refs/heads/master@{#436886} (cherry picked from commit 1b73086fba57f587b632d5c60c3e912317fa2613) Committed: https://chromium.googlesource.com/chromium/src/+/36abedc360f1cf489839caf254f7f0491bbd6a93

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -1 line)			Patch
M	third_party/WebKit/LayoutTests/TestExpectations	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-align.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-align-expected.html	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

kojii

4 years ago (2016-12-10 06:45:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
36abedc360f1cf489839caf254f7f0491bbd6a93.