Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2548333004: Fix not to double count the widths of hyphens (Closed)

Created:
4 years ago by kojii
Modified:
4 years ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix not to double count the widths of hyphens The widths of hyphens are added to BidiRun in LayoutBlockFlow, and should not be included in WordMeasurement. BUG=671129 Committed: https://crrev.com/1b73086fba57f587b632d5c60c3e912317fa2613 Cr-Commit-Position: refs/heads/master@{#436886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-align.html View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-align-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
kojii
PTAL.
4 years ago (2016-12-06 18:31:00 UTC) #7
eae
LGTM!
4 years ago (2016-12-07 07:17:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548333004/1
4 years ago (2016-12-07 07:18:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 07:23:09 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-07 07:25:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b73086fba57f587b632d5c60c3e912317fa2613
Cr-Commit-Position: refs/heads/master@{#436886}

Powered by Google App Engine
This is Rietveld 408576698