Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 2564163002: [Offline Pages] Remove load state from public OfflinePageModel API. (Closed)
Patch Set: Fix broken tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_bridge.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc
index ff555bac14340aa2ef2088fca53a36b4170a5f84..4507ecf109bf5e0ea282eb1497e99baeaecd41b9 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc
@@ -262,7 +262,6 @@ OfflinePageBridge::OfflinePageBridge(JNIEnv* env,
Java_OfflinePageBridge_create(env, reinterpret_cast<jlong>(this));
java_ref_.Reset(j_offline_page_bridge);
- NotifyIfDoneLoading();
offline_page_model_->AddObserver(this);
}
@@ -273,11 +272,6 @@ OfflinePageBridge::~OfflinePageBridge() {
Java_OfflinePageBridge_offlinePageBridgeDestroyed(env, java_ref_);
}
-void OfflinePageBridge::OfflinePageModelLoaded(OfflinePageModel* model) {
- DCHECK_EQ(offline_page_model_, model);
- NotifyIfDoneLoading();
-}
-
void OfflinePageBridge::OfflinePageAdded(OfflinePageModel* model,
const OfflinePageItem& added_page) {
DCHECK_EQ(offline_page_model_, model);
@@ -556,14 +550,6 @@ void OfflinePageBridge::RemoveRequestsFromQueue(
request_ids, base::Bind(&OnRemoveRequestsDone, j_callback_ref));
}
-void OfflinePageBridge::NotifyIfDoneLoading() const {
- if (!offline_page_model_->is_loaded())
- return;
- JNIEnv* env = base::android::AttachCurrentThread();
- Java_OfflinePageBridge_offlinePageModelLoaded(env, java_ref_);
-}
-
-
ScopedJavaLocalRef<jobject> OfflinePageBridge::CreateClientId(
JNIEnv* env,
const ClientId& client_id) const {

Powered by Google App Engine
This is Rietveld 408576698