Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3721)

Unified Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2564163002: [Offline Pages] Remove load state from public OfflinePageModel API. (Closed)
Patch Set: Fix broken tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
diff --git a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
index 10612b1268b21d264a666ad2167818845fd10e5c..5be7d972b26f25da7b2dde76a6939a4ba7754000 100644
--- a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
+++ b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
@@ -212,7 +212,6 @@ OfflinePageEvaluationBridge::OfflinePageEvaluationBridge(
java_ref_.Reset(Java_OfflinePageEvaluationBridge_create(
env, reinterpret_cast<jlong>(this)));
- NotifyIfDoneLoading();
offline_page_model_->AddObserver(this);
request_coordinator_->AddObserver(this);
offline_page_model_->GetLogger()->SetClient(this);
@@ -226,12 +225,6 @@ OfflinePageEvaluationBridge::~OfflinePageEvaluationBridge() {
}
// Implement OfflinePageModel::Observer
-void OfflinePageEvaluationBridge::OfflinePageModelLoaded(
- OfflinePageModel* model) {
- DCHECK_EQ(offline_page_model_, model);
- NotifyIfDoneLoading();
-}
-
void OfflinePageEvaluationBridge::OfflinePageAdded(
OfflinePageModel* model,
const OfflinePageItem& added_page) {}
@@ -337,12 +330,5 @@ void OfflinePageEvaluationBridge::RemoveRequestsFromQueue(
request_ids, base::Bind(&OnRemoveRequestsDone, j_callback_ref));
}
-void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const {
- if (!offline_page_model_->is_loaded())
- return;
- JNIEnv* env = base::android::AttachCurrentThread();
- Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_);
-}
-
} // namespace android
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698