chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java - Issue 2564163002: [Offline Pages] Remove load state from public OfflinePageModel API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

Issue 2564163002: [Offline Pages] Remove load state from public OfflinePageModel API. (Closed)

Patch Set: Fix broken tests. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java ('K') | « chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/FakeOfflinePageBridge.java ('k') | chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h » ('j') | chrome/browser/ntp_snippets/download_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

index 8759db0260fd0857464df4519998202982dd5e04..3be33af8df2aebe03cd046c9b9214e383fa357dd 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

@@ -195,7 +195,6 @@ public class SuggestionsSectionTest {

final OfflinePageItem item0 = createOfflinePageItem(snippets.get(0).mUrl, 0L);

final OfflinePageItem item1 = createOfflinePageItem(snippets.get(1).mUrl, 1L);

- mBridge.setIsOfflinePageModelLoaded(true);

mBridge.setItems(Arrays.asList(item0, item1));

SuggestionsSection section = createSectionWithReloadAction(true);

@@ -207,11 +206,10 @@ public class SuggestionsSectionTest {

assertNull(snippets.get(2).getOfflinePageOfflineId());

final OfflinePageItem item2 = createOfflinePageItem(snippets.get(2).mUrl, 2L);

mBridge.setItems(Arrays.asList(item1, item2));

+ mBridge.fireOfflinePageAdded(item2);

// Check that a change in OfflinePageBridge state forces an update.

- mBridge.fireOfflinePageModelLoaded();

assertNull(snippets.get(0).getOfflinePageOfflineId());

assertEquals(Long.valueOf(1L), snippets.get(1).getOfflinePageOfflineId());

assertEquals(Long.valueOf(2L), snippets.get(2).getOfflinePageOfflineId());