Issue 2564143003: TSAN startup fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2564143003: TSAN startup fix (Closed)

Created:
4 years ago by Alexei Svitkine (slow)

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

TSAN startup fix We were hitting a lock order inversion deadlock, due to one thread holding the lock in field_trial.cc and trying to hold the lock in field_trial_param_associator.cc and another doing the opposite. This fixes that. BUG=671282 Review-Url: https://codereview.chromium.org/2560823002 Cr-Commit-Position: refs/heads/master@{#436987} (cherry picked from commit 7f262eb07e82a53a561800998a9b2f5418534bdf) Committed: https://chromium.googlesource.com/chromium/src/+/170e4101936172efbbe561ea85296890d157ba2c

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	base/metrics/field_trial_param_associator.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

Alexei Svitkine (slow)

4 years ago (2016-12-09 19:25:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
170e4101936172efbbe561ea85296890d157ba2c.