Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2560823002: TSAN startup fix (Closed)

Created:
4 years ago by lawrencewu
Modified:
4 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TSAN startup fix We were hitting a lock order inversion deadlock, due to one thread holding the lock in field_trial.cc and trying to hold the lock in field_trial_param_associator.cc and another doing the opposite. This fixes that. BUG=671282 Committed: https://crrev.com/7f262eb07e82a53a561800998a9b2f5418534bdf Cr-Commit-Position: refs/heads/master@{#436987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M base/metrics/field_trial_param_associator.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
lawrencewu
4 years ago (2016-12-07 15:35:34 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years ago (2016-12-07 15:46:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560823002/1
4 years ago (2016-12-07 15:48:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 17:07:42 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-07 17:11:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f262eb07e82a53a561800998a9b2f5418534bdf
Cr-Commit-Position: refs/heads/master@{#436987}

Powered by Google App Engine
This is Rietveld 408576698