Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256413004: Relayout windows in overview when display size changes. (Closed)

Created:
6 years, 8 months ago by flackr
Modified:
6 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, tdanderson+overview_chromium.org, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Relayout windows in overview when display size changes. BUG=359672 TEST=WindowSelectorTest.DisplayOrientationChanged TEST=While overview is active, rotate or resize the display. Windows should reposition / relayout in response. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266388

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : Merge and remove extra newline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -41 lines) Patch
M ash/wm/overview/window_overview.h View 4 chunks +12 lines, -4 lines 0 comments Download
M ash/wm/overview/window_overview.cc View 1 8 chunks +25 lines, -10 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_item.h View 2 chunks +7 lines, -5 lines 0 comments Download
M ash/wm/overview/window_selector_item.cc View 3 chunks +17 lines, -11 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download
M ash/wm/overview/window_selector_window.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_window.cc View 3 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
flackr
This does a relayout of the windows in overview if the display size changes. The ...
6 years, 8 months ago (2014-04-24 03:27:52 UTC) #1
flackr
ping?
6 years, 8 months ago (2014-04-25 15:42:46 UTC) #2
oshima
lgtm https://codereview.chromium.org/256413004/diff/20001/ash/wm/overview/window_selector_unittest.cc File ash/wm/overview/window_selector_unittest.cc (right): https://codereview.chromium.org/256413004/diff/20001/ash/wm/overview/window_selector_unittest.cc#newcode1178 ash/wm/overview/window_selector_unittest.cc:1178: nuke extra line
6 years, 8 months ago (2014-04-25 16:13:38 UTC) #3
flackr
https://codereview.chromium.org/256413004/diff/20001/ash/wm/overview/window_selector_unittest.cc File ash/wm/overview/window_selector_unittest.cc (right): https://codereview.chromium.org/256413004/diff/20001/ash/wm/overview/window_selector_unittest.cc#newcode1178 ash/wm/overview/window_selector_unittest.cc:1178: On 2014/04/25 16:13:39, oshima wrote: > nuke extra line ...
6 years, 8 months ago (2014-04-25 16:15:53 UTC) #4
flackr
The CQ bit was checked by flackr@chromium.org
6 years, 8 months ago (2014-04-25 16:15:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/256413004/40001
6 years, 8 months ago (2014-04-25 22:15:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 04:29:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-26 04:29:54 UTC) #8
flackr
The CQ bit was checked by flackr@chromium.org
6 years, 8 months ago (2014-04-26 14:42:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/256413004/40001
6 years, 8 months ago (2014-04-26 14:43:46 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 22:33:13 UTC) #11
Message was sent while issue was closed. 
Change committed as 266388

Powered by Google App Engine
This is Rietveld 408576698