Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 2564063002: [Cronet] Expose ExperimentalCronetEngine.Builder.getBuilderDelegate() for tests (Closed)

Created:
4 years ago by pauljensen
Modified:
4 years ago
Reviewers:
kapishnikov, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Expose ExperimentalCronetEngine.Builder.getBuilderDelegate() for tests Moved from package-private to public, but @hide. Having it be package-private disallows having tests in another package. BUG=629299 R=kapishnikov CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Committed: https://crrev.com/d3f04a34ae343adf1ebda48c4e9f8b8a3f6c5623 Cr-Commit-Position: refs/heads/master@{#437914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
pauljensen
Andrei, WDYT?
4 years ago (2016-12-09 15:47:14 UTC) #2
pauljensen
Misha, PTAL while Andrei is out, thank you!
4 years ago (2016-12-12 17:54:49 UTC) #4
mef
lgtm
4 years ago (2016-12-12 19:20:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564063002/1
4 years ago (2016-12-12 19:34:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 21:22:12 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-12 21:25:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3f04a34ae343adf1ebda48c4e9f8b8a3f6c5623
Cr-Commit-Position: refs/heads/master@{#437914}

Powered by Google App Engine
This is Rietveld 408576698