Supervised Users: Create ResourceThrottle only if filtering is enabled

Supervised Users: Create ResourceThrottle only if filtering is enabled

Before this CL, we were creating a SupervisedUserResourceThrottle for
each top-level navigation. If the current user isn't supervised, this is
pointless. One side-effect was that we were recording
ManagerUsers.Filter* histograms for all navigations, including for
non-supervised users.

This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
to true iff the user is supervised. This allows us to not create the
resource throttle for regular users.

BUG=671472
Committed: https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
Cr-Commit-Position: refs/heads/master@{#437868}

[Marc Treib, 2016-12-09 15:30:51]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-12-09 15:30:52]

PTAL!

[Bernhard Bauer, 2016-12-12 12:20:21]

lgtm

[Marc Treib, 2016-12-12 13:01:00]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 13:01:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 14:20:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 14:20:37]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-12-12 14:21:25]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-12-12 14:21:25]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2564043002/#ps40001
(title: "update SearchTest")

[commit-bot: I haz the power, 2016-12-12 14:21:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 14:28:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481552485398140,
"parent_rev": "f67316984947e6c049de69c8490341aa2654d243", "commit_rev":
"b505a13674af7884213b97d7c69322360a534c2d"}

[commit-bot: I haz the power, 2016-12-12 14:28:33]

Description was changed from

==========
Supervised Users: Create ResourceThrottle only if filtering is enabled

Before this CL, we were creating a SupervisedUserResourceThrottle for
each top-level navigation. If the current user isn't supervised, this is
pointless. One side-effect was that we were recording
ManagerUsers.Filter* histograms for all navigations, including for
non-supervised users.

This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
to true iff the user is supervised. This allows us to not create the
resource throttle for regular users.

BUG=671472
==========

to

==========
Supervised Users: Create ResourceThrottle only if filtering is enabled

Before this CL, we were creating a SupervisedUserResourceThrottle for
each top-level navigation. If the current user isn't supervised, this is
pointless. One side-effect was that we were recording
ManagerUsers.Filter* histograms for all navigations, including for
non-supervised users.

This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
to true iff the user is supervised. This allows us to not create the
resource throttle for regular users.

BUG=671472

Review-Url: https://codereview.chromium.org/2564043002
==========

[commit-bot: I haz the power, 2016-12-12 14:28:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-12 15:12:10]

Description was changed from

==========
Supervised Users: Create ResourceThrottle only if filtering is enabled

Before this CL, we were creating a SupervisedUserResourceThrottle for
each top-level navigation. If the current user isn't supervised, this is
pointless. One side-effect was that we were recording
ManagerUsers.Filter* histograms for all navigations, including for
non-supervised users.

This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
to true iff the user is supervised. This allows us to not create the
resource throttle for regular users.

BUG=671472

Review-Url: https://codereview.chromium.org/2564043002
==========

to

==========
Supervised Users: Create ResourceThrottle only if filtering is enabled

Before this CL, we were creating a SupervisedUserResourceThrottle for
each top-level navigation. If the current user isn't supervised, this is
pointless. One side-effect was that we were recording
ManagerUsers.Filter* histograms for all navigations, including for
non-supervised users.

This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
to true iff the user is supervised. This allows us to not create the
resource throttle for regular users.

BUG=671472

Committed: https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
Cr-Commit-Position: refs/heads/master@{#437868}
==========

[commit-bot: I haz the power, 2016-12-12 15:12:10]

Patchset 3 (id:??) landed as
https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
Cr-Commit-Position: refs/heads/master@{#437868}

[bpastene, 2016-12-12 20:26:47]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2568953002/ by bpastene@chromium.org.

The reason for reverting is: This is believed to have increased the rate of
failure for SupervisedUserContentProviderTest#testWithSupervisedUser on
linux_android_rel_ng.

See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
for dramatic increase in failure rate after this CL landed.

Example failure: https://chromium-swarm.appspot.com/task?id=330d0f66aec28810.