Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2564033002:
CQ commit, which should be self-numbered. (Closed)
|
Created:
4 years ago by tandrii(chromium) Modified:
4 years ago Reviewers:
Michael Achenbach CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/gnumb-test/cq Project:
v8 Visibility:
Public. |
DescriptionCQ commit, which should be self-numbered.
NOTRY=True
NOPRESUBMIT=True
TBR=machenbach@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2564033002
Cr-Commit-Position: refs/heads/gnumb-test/cq@{#3}
Cr-Branched-From: 5c49df2da689e4374ea073a89714b4597283d138-refs/heads/master@{#41618}
Patch Set 1 #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 31 (14 generated)
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry for the inconvenience.
lgtm
The CQ bit was checked by tandrii@chromium.org
The CQ bit was unchecked by tandrii@chromium.org
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry for the inconvenience.
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry for the inconvenience.
The CQ bit was unchecked by tandrii@chromium.org
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481731403422790, "parent_rev":
"7a7781c6413c30bbe96766719bc5b011bf49107d", "commit_rev":
"72a8cf1f8ced53ab29ee7a8cf41b6d33faf230b3"}
Message was sent while issue was closed.
Description was changed from ========== CQ commit, which should be self-numbered. NOTRY=True NOPRESUBMIT=True TBR=machenbach@chromium.org BUG= ========== to ========== CQ commit, which should be self-numbered. NOTRY=True NOPRESUBMIT=True TBR=machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2564033002 Cr-Commit-Position: refs/heads/gnumb-test/cq@{#3} Cr-Branched-From: 5c49df2da689e4374ea073a89714b4597283d138-refs/heads/master@{#41618} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
This CL is hereby first git-numbered CL by CQ :)
Message was sent while issue was closed.
On 2016/12/14 16:04:30, tandrii(chromium) wrote: > This CL is hereby first git-numbered CL by CQ :) \o/ Two things: 1. Shouldn't there be a message from CQ with the real commit hash and a link? I.e. the same thing the commit position bot did before? 2. Is it now normal that we get the footers in the commit description here in code review?
Message was sent while issue was closed.
On 2016/12/14 19:15:35, Michael Achenbach wrote: > On 2016/12/14 16:04:30, tandrii(chromium) wrote: > > This CL is hereby first git-numbered CL by CQ :) > > \o/ > > Two things: > 1. Shouldn't there be a message from CQ with the real commit hash and a link? > I.e. the same thing the commit position bot did before? Ah, i forgot to send CL to you: https://chrome-internal-review.googlesource.com/c/311738/ it fixes precisely this. > 2. Is it now normal that we get the footers in the commit description here in > code review? It's a new normal. Is it bad?
Message was sent while issue was closed.
> > 2. Is it now normal that we get the footers in the commit description here in > > code review? > It's a new normal. Is it bad? I can probably get used to it. Is it easier from a code p-o-v? Or is it solving any particular problem? Personally my opinion about this is twofold: - If I look at a code review later, I fine too much of this technical boilerplate disturbing. I'm usually looking for the human description or a bug link. - It is good from a consistency p-o-v. Having commit and code review show the same thing.
Message was sent while issue was closed.
On 2016/12/14 21:11:00, Michael Achenbach wrote: > > > 2. Is it now normal that we get the footers in the commit description here > in > > > code review? > > It's a new normal. Is it bad? > > I can probably get used to it. Is it easier from a code p-o-v? Or is it solving > any particular problem? Yep, at the time i coded it. If I were to code it now, it wouldn't make a difference, but I won't do any changes now that I expect to dump all this code anyway. > Personally my opinion about this is twofold: > - If I look at a code review later, I fine too much of this technical > boilerplate disturbing. I'm usually looking for the human description or a bug > link. Agree here. We may eventually take all footers into metadata, but that'd be way after we switch to Gerrit. This will bring us closer to internal Google's Critique. > - It is good from a consistency p-o-v. Having commit and code review show the > same thing. Gerrit will have this displayed, so you'd have to get used to it. Luckily, for master branch it's just 2 lines. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
