Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 2563893002: [MD settings] move adobe storage settings button out of site-settings-category (Closed)

Created:
4 years ago by dschuyler
Modified:
4 years ago
Reviewers:
tommycli, Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] move adobe storage settings button out of site-settings-category This CL moves a button that is only shown in the plugins category to the instantiation of that category. That helps clean up the site-settings-category page. This also changes the cookies-control selector to an extra-options selector that is shared with the adobe storage settings button. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3ce32016535741fa283806af51fd97d0b08ce194 Cr-Commit-Position: refs/heads/master@{#437638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -29 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_category.html View 1 chunk +1 line, -12 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_category.js View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
dschuyler
Hi Tommy, in CL 2554403005 you'd suggested that a bit of that CL could be ...
4 years ago (2016-12-09 02:11:35 UTC) #6
Dan Beam
sweet, lgtm
4 years ago (2016-12-09 02:14:39 UTC) #8
tommycli
lgtm thank you!
4 years ago (2016-12-09 18:32:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563893002/1
4 years ago (2016-12-09 19:36:13 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 20:49:40 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-12 14:40:20 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ce32016535741fa283806af51fd97d0b08ce194
Cr-Commit-Position: refs/heads/master@{#437638}

Powered by Google App Engine
This is Rietveld 408576698