DevTools: sort non-enumerable and underscore properties lower in logged object

DevTools: sort non-enumerable and underscore properties lower in logged object

BUG=665948
Committed: https://crrev.com/67cb47ca97220d46c56d9c4ab7619753e4f2dd56
Cr-Commit-Position: refs/heads/master@{#438067}

[luoe, 2016-12-09 01:36:56]

Description was changed from

==========
DevTools: sort non-enumerable properties lower in object

BUG=665948
==========

to

==========
DevTools: sort non-enumerable properties lower in logged object

BUG=665948
==========

[luoe, 2016-12-09 01:41:33]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2016-12-09 01:41:34]

Please take a look

https://codereview.chromium.org/2563883002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
(right):

https://codereview.chromium.org/2563883002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js:349:
func.description, includePreview, defaultName);
This was a drive-by change.  Clang format found this to be an error, and the
last person who worked on this file was me, so I think it's fine.

[luoe, 2016-12-09 01:53:17]

Description was changed from

==========
DevTools: sort non-enumerable properties lower in logged object

BUG=665948
==========

to

==========
DevTools: sort non-enumerable and underscore properties lower in logged object

BUG=665948
==========

[lushnikov, 2016-12-09 19:36:29]

lgtm

[luoe, 2016-12-09 19:41:31]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 19:42:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 19:46:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 19:46:46]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[luoe, 2016-12-12 18:29:39]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 18:30:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 20:28:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 20:28:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[luoe, 2016-12-13 03:05:26]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 03:05:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 04:32:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 04:32:26]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-12-13 05:38:02]

The CQ bit was checked by luoe@chromium.org

[luoe, 2016-12-13 05:38:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2563883002/#ps60001
(title: "rebase again")

[commit-bot: I haz the power, 2016-12-13 05:38:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 05:42:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481607482018010,
"parent_rev": "f3974996e2b1b3e035c406fc30f054653e6a1738", "commit_rev":
"dd0cb99b71d228416a575dd2b35bad83f4a34110"}

[commit-bot: I haz the power, 2016-12-13 05:43:15]

Description was changed from

==========
DevTools: sort non-enumerable and underscore properties lower in logged object

BUG=665948
==========

to

==========
DevTools: sort non-enumerable and underscore properties lower in logged object

BUG=665948

Review-Url: https://codereview.chromium.org/2563883002
==========

[commit-bot: I haz the power, 2016-12-13 05:43:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-13 05:46:37]

Description was changed from

==========
DevTools: sort non-enumerable and underscore properties lower in logged object

BUG=665948

Review-Url: https://codereview.chromium.org/2563883002
==========

to

==========
DevTools: sort non-enumerable and underscore properties lower in logged object

BUG=665948

Committed: https://crrev.com/67cb47ca97220d46c56d9c4ab7619753e4f2dd56
Cr-Commit-Position: refs/heads/master@{#438067}
==========

[commit-bot: I haz the power, 2016-12-13 05:46:38]

Patchset 4 (id:??) landed as
https://crrev.com/67cb47ca97220d46c56d9c4ab7619753e4f2dd56
Cr-Commit-Position: refs/heads/master@{#438067}