Clear navigation_handle early in RenderFrameHostImpl destructor.

Clear navigation_handle early in RenderFrameHostImpl destructor.

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/5f8c1ef3e2a4f1f2f9aac1d6d3ad1a270538ae24
Cr-Commit-Position: refs/heads/master@{#437658}

[dgozman, 2016-12-09 01:03:19]

Description was changed from

==========
Clear navigtaion_handle early in RenderFrameHostImpl desctructor.

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
==========

to

==========
Clear navigtaion_handle early in RenderFrameHostImpl desctructor.

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[dgozman, 2016-12-09 01:04:41]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2016-12-09 01:05:13]

dgozman@chromium.org changed reviewers:
+ clamy@chromium.org, pfeldman@chromium.org, samuong@chromium.org

[dgozman, 2016-12-09 01:05:14]

Could you please take a look? This is a follow up to our discussion here:
https://codereview.chromium.org/2544893002/.

[commit-bot: I haz the power, 2016-12-09 01:05:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 03:48:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 03:48:51]

Dry run: This issue passed the CQ dry run.

[samuong, 2016-12-09 04:13:45]

combining this with my cl (see https://codereview.chromium.org/2387353004/)
fixes the error i was seeing in
DevToolsManagerTest.ReattachOnCancelPendingNavigation

results:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

so lgtm, but i'll let clamy@ take a closer look at the code since this is an
area i'm not very familiar with

one nit: "navigation_handle" and "destructor" are misspelt in the
subject/description

[dgozman, 2016-12-09 05:52:56]

Description was changed from

==========
Clear navigtaion_handle early in RenderFrameHostImpl desctructor.

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Clear navigation_handle early in RenderFrameHostImpl destructor.

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[dgozman, 2016-12-09 05:53:23]

On 2016/12/09 04:13:45, samuong wrote:
> combining this with my cl (see https://codereview.chromium.org/2387353004/)
> fixes the error i was seeing in
> DevToolsManagerTest.ReattachOnCancelPendingNavigation
> 
> results:
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
Thank you for verification.

> 
> so lgtm, but i'll let clamy@ take a closer look at the code since this is an
> area i'm not very familiar with
> 
> one nit: "navigation_handle" and "destructor" are misspelt in the
> subject/description
Fixed.

[clamy, 2016-12-09 14:16:20]

Thanks! Lgtm.

[dgozman, 2016-12-09 21:01:49]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-12-09 21:03:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 21:15:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481317309457730, "parent_rev":
"aeb2dfc6af5da9fb59645de7a4c6b033714bb34d", "commit_rev":
"a8b3ed12f931c01cdc469e703becbeefb70da49c"}

[commit-bot: I haz the power, 2016-12-09 21:16:20]

Description was changed from

==========
Clear navigation_handle early in RenderFrameHostImpl destructor.

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Clear navigation_handle early in RenderFrameHostImpl destructor.

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2563863002
==========

[commit-bot: I haz the power, 2016-12-09 21:16:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 14:41:02]

Description was changed from

==========
Clear navigation_handle early in RenderFrameHostImpl destructor.

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2563863002
==========

to

==========
Clear navigation_handle early in RenderFrameHostImpl destructor.

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/5f8c1ef3e2a4f1f2f9aac1d6d3ad1a270538ae24
Cr-Commit-Position: refs/heads/master@{#437658}
==========

[commit-bot: I haz the power, 2016-12-12 14:41:03]

Patchset 1 (id:??) landed as
https://crrev.com/5f8c1ef3e2a4f1f2f9aac1d6d3ad1a270538ae24
Cr-Commit-Position: refs/heads/master@{#437658}