|
|
Chromium Code Reviews
Description[C4A] Remove NavigationEntryTest.NavigationEntryURLs test on audio builds.
Audio only devices have no way to display a URL, so unittest is irrelevant.
BUG= internal b/32972133
TEST= content_unittests
Change-Id: Ic901fdba822b042726d2f26a3cb07413652d7157
Committed: https://crrev.com/27e7928aaf51c01ffcc171bf0676cbf0a00181c5
Cr-Commit-Position: refs/heads/master@{#437698}
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
bshaya@google.com changed reviewers: + almasrymina@chromium.org, mbjorge@chromium.org
mbjorge@chromium.org changed reviewers: + slan@chromium.org
lgtm +slan as chromium committer
lgtm lgtm
The CQ bit was checked by mbjorge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by bshaya@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mbjorge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481323502414950, "parent_rev":
"3a98d9b182540acdd5310e2b5ef19cac3a9ce5b4", "commit_rev":
"d0f2351e2cb9a8d68fe7082a036d2ac9fd914cde"}
Message was sent while issue was closed.
Description was changed from ========== [C4A] Remove NavigationEntryTest.NavigationEntryURLs test on audio builds. Audio only devices have no way to display a URL, so unittest is irrelevant. BUG= internal b/32972133 TEST= content_unittests Change-Id: Ic901fdba822b042726d2f26a3cb07413652d7157 ========== to ========== [C4A] Remove NavigationEntryTest.NavigationEntryURLs test on audio builds. Audio only devices have no way to display a URL, so unittest is irrelevant. BUG= internal b/32972133 TEST= content_unittests Change-Id: Ic901fdba822b042726d2f26a3cb07413652d7157 Review-Url: https://codereview.chromium.org/2563833002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [C4A] Remove NavigationEntryTest.NavigationEntryURLs test on audio builds. Audio only devices have no way to display a URL, so unittest is irrelevant. BUG= internal b/32972133 TEST= content_unittests Change-Id: Ic901fdba822b042726d2f26a3cb07413652d7157 Review-Url: https://codereview.chromium.org/2563833002 ========== to ========== [C4A] Remove NavigationEntryTest.NavigationEntryURLs test on audio builds. Audio only devices have no way to display a URL, so unittest is irrelevant. BUG= internal b/32972133 TEST= content_unittests Change-Id: Ic901fdba822b042726d2f26a3cb07413652d7157 Committed: https://crrev.com/27e7928aaf51c01ffcc171bf0676cbf0a00181c5 Cr-Commit-Position: refs/heads/master@{#437698} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/27e7928aaf51c01ffcc171bf0676cbf0a00181c5 Cr-Commit-Position: refs/heads/master@{#437698} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
