Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2563833002: [C4A] Remove NavigationEntryTest.NavigationEntryURLs test on audio builds. (Closed)

Created:
4 years ago by bshaya
Modified:
4 years ago
Reviewers:
slan, almasrymina, mbjorge
CC:
alokp+watch_chromium.org, chromium-reviews, halliwell+watch_chromium.org, lcwu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[C4A] Remove NavigationEntryTest.NavigationEntryURLs test on audio builds. Audio only devices have no way to display a URL, so unittest is irrelevant. BUG= internal b/32972133 TEST= content_unittests Change-Id: Ic901fdba822b042726d2f26a3cb07413652d7157 Committed: https://crrev.com/27e7928aaf51c01ffcc171bf0676cbf0a00181c5 Cr-Commit-Position: refs/heads/master@{#437698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chromecast/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
bshaya
4 years ago (2016-12-08 23:56:52 UTC) #2
mbjorge
lgtm +slan as chromium committer
4 years ago (2016-12-08 23:59:37 UTC) #4
slan
lgtm lgtm
4 years ago (2016-12-09 00:07:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563833002/1
4 years ago (2016-12-09 00:09:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/177574)
4 years ago (2016-12-09 00:22:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563833002/1
4 years ago (2016-12-09 22:46:12 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 23:41:52 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-12 14:58:37 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27e7928aaf51c01ffcc171bf0676cbf0a00181c5
Cr-Commit-Position: refs/heads/master@{#437698}

Powered by Google App Engine
This is Rietveld 408576698