|
|
Chromium Code Reviews
DescriptionAdd nogncheck to a WebRTC header to suppress gn check error.
Running this command will throw an error:
gn gen out/Release --check --args="is_debug=false enable_webrtc=false"
Fix this error by adding a nogncheck comment by the errant include.
BUG=
Committed: https://crrev.com/d4a8c49be95d142a8d0c234c45ec378be4a42e8f
Cr-Commit-Position: refs/heads/master@{#438041}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== Add nogncheck to a WebRTC header to suppress gn check error. Running this command will throw an error: gn gen out/Release --check --args="is_debug=false enable_webrtc=true" Fix this error by adding a nogncheck comment by the errant include. BUG= ========== to ========== Add nogncheck to a WebRTC header to suppress gn check error. Running this command will throw an error: gn gen out/Release --check --args="is_debug=false enable_webrtc=false" Fix this error by adding a nogncheck comment by the errant include. BUG= ==========
The CQ bit was checked by slan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
slan@chromium.org changed reviewers: + sky@chromium.org
Scott, please have a look!
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by slan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by slan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481595849110530, "parent_rev":
"94de0fad189c6dbae43541dc10e470fa84a5f2dc", "commit_rev":
"7fc19569f49b3f383e7f983ad880bccc590a19b6"}
Message was sent while issue was closed.
Description was changed from ========== Add nogncheck to a WebRTC header to suppress gn check error. Running this command will throw an error: gn gen out/Release --check --args="is_debug=false enable_webrtc=false" Fix this error by adding a nogncheck comment by the errant include. BUG= ========== to ========== Add nogncheck to a WebRTC header to suppress gn check error. Running this command will throw an error: gn gen out/Release --check --args="is_debug=false enable_webrtc=false" Fix this error by adding a nogncheck comment by the errant include. BUG= Review-Url: https://codereview.chromium.org/2563773003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add nogncheck to a WebRTC header to suppress gn check error. Running this command will throw an error: gn gen out/Release --check --args="is_debug=false enable_webrtc=false" Fix this error by adding a nogncheck comment by the errant include. BUG= Review-Url: https://codereview.chromium.org/2563773003 ========== to ========== Add nogncheck to a WebRTC header to suppress gn check error. Running this command will throw an error: gn gen out/Release --check --args="is_debug=false enable_webrtc=false" Fix this error by adding a nogncheck comment by the errant include. BUG= Committed: https://crrev.com/d4a8c49be95d142a8d0c234c45ec378be4a42e8f Cr-Commit-Position: refs/heads/master@{#438041} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d4a8c49be95d142a8d0c234c45ec378be4a42e8f Cr-Commit-Position: refs/heads/master@{#438041} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
