Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2563773003: Add nogncheck to a WebRTC header to suppress gn check error. (Closed)

Created:
4 years ago by slan
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add nogncheck to a WebRTC header to suppress gn check error. Running this command will throw an error: gn gen out/Release --check --args="is_debug=false enable_webrtc=false" Fix this error by adding a nogncheck comment by the errant include. BUG= Committed: https://crrev.com/d4a8c49be95d142a8d0c234c45ec378be4a42e8f Cr-Commit-Position: refs/heads/master@{#438041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
slan
Scott, please have a look!
4 years ago (2016-12-08 23:33:25 UTC) #5
sky
LGTM
4 years ago (2016-12-08 23:42:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563773003/1
4 years ago (2016-12-08 23:52:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/206101)
4 years ago (2016-12-08 23:59:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563773003/1
4 years ago (2016-12-13 02:24:56 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 03:47:30 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-13 03:49:21 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4a8c49be95d142a8d0c234c45ec378be4a42e8f
Cr-Commit-Position: refs/heads/master@{#438041}

Powered by Google App Engine
This is Rietveld 408576698