DevTools: roll closure compiler to 20161201.

DevTools: roll closure compiler to 20161201.

R=alph@chromium.org

Committed: https://crrev.com/ffb21014128ff2e256f6a6280fe59d7e2bf70a78
Cr-Commit-Position: refs/heads/master@{#437600}

[pfeldman, 2016-12-09 01:25:55]

pfeldman@chromium.org changed reviewers:
+ chenwilliam@chromium.org, dgozman@chromium.org

[alph, 2016-12-09 02:41:49]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-12-09 02:41:49]

lgtm

[pfeldman, 2016-12-09 02:56:35]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-12-09 02:57:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 03:00:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 03:00:08]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kozy, 2016-12-09 03:03:44]

kozyatinskiy@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[kozy, 2016-12-09 03:03:45]

https://codereview.chromium.org/2563763003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/compile_frontend.py (right):

https://codereview.chromium.org/2563763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/compile_frontend.py:259:
'--module_output_path_prefix', to_platform_path_exact(modules_dir + path.sep)
When I rolled compiler for injected-script-source and debugger-script in V8 I
used --new_type_inf flag and it looks like it caught more type errors in these
scripts, we can try to use it for frontend.

[chenwilliam, 2016-12-09 04:00:54]

Just double checking to see if you used JDK 7 to compile these jars, otherwise
they won't run on buildbot (they are on 7 and not 8, which is the default on our
workstations). There's note in the internal site on using JDK 7 in the "Rolling
Closure Compiler" section.

[pfeldman, 2016-12-09 18:51:17]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-12-09 18:51:18]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2563763003/#ps20001
(title: "rebaselined")

[pfeldman, 2016-12-09 18:51:39]

On 2016/12/09 04:00:54, chenwilliam wrote:
> Just double checking to see if you used JDK 7 to compile these jars, otherwise
> they won't run on buildbot (they are on 7 and not 8, which is the default on
our
> workstations). There's note in the internal site on using JDK 7 in the
"Rolling
> Closure Compiler" section.

added --target 7 so that you did not have to double check next time :)

[commit-bot: I haz the power, 2016-12-09 18:52:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 18:55:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 18:55:16]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-12-09 19:08:10]

Description was changed from

==========
DevTools: roll closure compiler to 20161201.
==========

to

==========
DevTools: roll closure compiler to 20161201.

R=alph@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/ffb21014128ff2e256f6a6280fe5...
==========

[pfeldman, 2016-12-09 19:08:11]

Committed patchset #2 (id:20001) manually as
ffb21014128ff2e256f6a6280fe59d7e2bf70a78 (presubmit successful).

[commit-bot: I haz the power, 2016-12-12 14:36:39]

Description was changed from

==========
DevTools: roll closure compiler to 20161201.

R=alph@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/ffb21014128ff2e256f6a6280fe5...
==========

to

==========
DevTools: roll closure compiler to 20161201.

R=alph@chromium.org

Committed: https://crrev.com/ffb21014128ff2e256f6a6280fe59d7e2bf70a78
Cr-Commit-Position: refs/heads/master@{#437600}
==========