third_party/WebKit/Source/devtools/scripts/jsdoc_validator/build_jsdoc_validator_jar.py - Issue 2563763003: DevTools: roll closure compiler to 20161201.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/scripts/jsdoc_validator/build_jsdoc_validator_jar.py

Issue 2563763003: DevTools: roll closure compiler to 20161201. (Closed)

Patch Set: rebaselined Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/scripts/compile_frontend.py ('k') | third_party/WebKit/Source/devtools/scripts/jsdoc_validator/hashes » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/scripts/jsdoc_validator/build_jsdoc_validator_jar.py

diff --git a/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/build_jsdoc_validator_jar.py b/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/build_jsdoc_validator_jar.py

index fd5f02def31825da2b320d296e12b3f96b1bacb4..07fd5bc383a6eb05b8f5c07bef5044f4aa00caf1 100755

--- a/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/build_jsdoc_validator_jar.py

+++ b/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/build_jsdoc_validator_jar.py

@@ -102,7 +102,7 @@ def build_artifacts():

manifest_file.write('Class-Path: %s\n' % closure_jar_relpath)

manifest_file.close()

javac_path = os.path.join(java_bin_path, 'javac')

- javac_command = '%s -d %s -cp %s %s' % (javac_path, bin_path, rel_to_abs(closure_jar_relpath), ' '.join(java_files))

+ javac_command = '%s -target 7 -source 7 -d %s -cp %s %s' % (javac_path, bin_path, rel_to_abs(closure_jar_relpath), ' '.join(java_files))

run_and_communicate(javac_command, 'Error: javac returned %d')

print 'Building jar...'