Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 2563723002: [Autoplay] Add more rappor metrics for autoplay in cross-origin iframes (Closed)

Created:
4 years ago by Zhiqiang Zhang (Slow)
Modified:
4 years ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autoplay] Add more rappor metrics for autoplay in cross-origin iframes This CL adds rappor metrics for recording the eTLD+1 of the top-level frame and cross-origin iframe when the user pauses an autoplaying video. BUG=672526 Committed: https://crrev.com/bdef306f2a6fbeea064ae552d063e4cee85dc5ec Cr-Commit-Position: refs/heads/master@{#437976}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.h View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp View 2 chunks +36 lines, -1 line 0 comments Download
M tools/metrics/rappor/rappor.xml View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Zhiqiang Zhang (Slow)
4 years ago (2016-12-08 18:21:19 UTC) #2
mlamouri (slow - plz ping)
lgtm but two high level comments: should we have histograms too? should we have unit ...
4 years ago (2016-12-10 12:16:56 UTC) #3
Zhiqiang Zhang (Slow)
On 2016/12/10 12:16:56, mlamouri wrote: > lgtm but two high level comments: should we have ...
4 years ago (2016-12-12 15:52:55 UTC) #4
Zhiqiang Zhang (Slow)
+holte for rappor.xml
4 years ago (2016-12-12 15:53:35 UTC) #6
Steven Holte
lgtm
4 years ago (2016-12-12 18:12:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563723002/20001
4 years ago (2016-12-12 18:45:07 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 01:22:58 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 01:26:06 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bdef306f2a6fbeea064ae552d063e4cee85dc5ec
Cr-Commit-Position: refs/heads/master@{#437976}

Powered by Google App Engine
This is Rietveld 408576698