Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2563703002: Reland Enable hermetic builds for iOS. (Closed)

Created:
4 years ago by justincohen
Modified:
4 years ago
Reviewers:
Robert Sesek, erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland enable hermetic builds for iOS. This is a reland of https://codereview.chromium.org/2546613004/ BUG=669094 TBR=kjellander@chromium.org Committed: https://crrev.com/cf1c482d102196f851d48f2faae1d44516a628ca Cr-Commit-Position: refs/heads/master@{#437326}

Patch Set 1 #

Patch Set 2 : Pass target_os from mac_toolchain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M build/mac/should_use_hermetic_xcode.py View 2 chunks +7 lines, -2 lines 0 comments Download
M build/mac_toolchain.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M build_overrides/build.gni View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
justincohen
This time without breaking mac_toolchain, see delta from patchset 1->2 for change. PTAL!
4 years ago (2016-12-08 18:19:53 UTC) #4
erikchen
lgtm
4 years ago (2016-12-08 18:20:57 UTC) #5
Robert Sesek
lgtm
4 years ago (2016-12-08 18:21:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563703002/20001
4 years ago (2016-12-08 20:06:01 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 20:40:09 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-08 20:42:17 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf1c482d102196f851d48f2faae1d44516a628ca
Cr-Commit-Position: refs/heads/master@{#437326}

Powered by Google App Engine
This is Rietveld 408576698