Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2246)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/mac_toolchain.py

Issue 2563703002: Reland Enable hermetic builds for iOS. (Closed)
Patch Set: Pass target_os from mac_toolchain Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/mac/should_use_hermetic_xcode.py ('k') | build_overrides/build.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/mac_toolchain.py
diff --git a/build/mac_toolchain.py b/build/mac_toolchain.py
index bec92a9e01b364848d25d4375d4574e617fbc713..dba2af87fcd6d2813c78963a870b1f193482ce97 100755
--- a/build/mac_toolchain.py
+++ b/build/mac_toolchain.py
@@ -157,7 +157,8 @@ def AcceptLicense():
def _UseHermeticToolchain():
current_dir = os.path.dirname(os.path.realpath(__file__))
script_path = os.path.join(current_dir, 'mac/should_use_hermetic_xcode.py')
- proc = subprocess.Popen([script_path], stdout=subprocess.PIPE)
+ target_os = 'ios' if IsIOSPlatform() else 'mac'
+ proc = subprocess.Popen([script_path, target_os], stdout=subprocess.PIPE)
return '1' in proc.stdout.readline()
« no previous file with comments | « build/mac/should_use_hermetic_xcode.py ('k') | build_overrides/build.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698