Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2563683003:
Enable PaintChunkerTest on windows debug build (Closed)
|
Created:
4 years ago by Xianzhu Modified:
4 years ago CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable PaintChunkerTest on windows debug build
BUG=629946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/acd3292620e912700a18c15346a9b1f391493279
Cr-Commit-Position: refs/heads/master@{#437775}
Patch Set 1 #Patch Set 2 : - #Patch Set 3 : In PaintChunker #Patch Set 4 : DisplayItemClient #Patch Set 5 : final #Messages
Total messages: 30 (25 generated)
Description was changed from ========== Enable PaintChunkerTest on windows debug build BUG=629946 ========== to ========== Enable PaintChunkerTest on windows debug build BUG=629946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #4 (id:60001) has been deleted
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #11 (id:220001) has been deleted
Patchset #11 (id:240001) has been deleted
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
wangxianzhu@chromium.org changed reviewers: + trchen@chromium.org
Swapping 'public DisplayItemClient' and 'public DisplayItem' didn't work. The tests still crashed on windows debug, and this time there were no crash stacks. Now use separate DisplayItemClient implementation to avoid the multi-inheritance.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Patchset #4 (id:80001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #3 (id:100001) has been deleted
Patchset #3 (id:120001) has been deleted
Patchset #3 (id:140001) has been deleted
Patchset #3 (id:160001) has been deleted
On 2016/12/10 at 02:07:59, wangxianzhu wrote: > Swapping 'public DisplayItemClient' and 'public DisplayItem' didn't work. The tests still crashed on windows debug, and this time there were no crash stacks. > > Now use separate DisplayItemClient implementation to avoid the multi-inheritance. LGTM
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 260001, "attempt_start_ts": 1481397505168200,
"parent_rev": "55cfb704f4736318091f150d99199da776af22ce", "commit_rev":
"3fc5d578b39045ae3990ea0c107c292116ab9149"}
Message was sent while issue was closed.
Description was changed from ========== Enable PaintChunkerTest on windows debug build BUG=629946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Enable PaintChunkerTest on windows debug build BUG=629946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2563683003 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:260001)
Message was sent while issue was closed.
Description was changed from ========== Enable PaintChunkerTest on windows debug build BUG=629946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2563683003 ========== to ========== Enable PaintChunkerTest on windows debug build BUG=629946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/acd3292620e912700a18c15346a9b1f391493279 Cr-Commit-Position: refs/heads/master@{#437775} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/acd3292620e912700a18c15346a9b1f391493279 Cr-Commit-Position: refs/heads/master@{#437775} |
