Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2563663002: [gmscore] Enable multidexing for various test targets (Closed)

Created:
4 years ago by dgn
Modified:
4 years ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, android-webview-reviews_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gmscore] Enable multidexing for various test targets Java tests that involve building dex files can reach the dex method limit when their dependencies pull at lot of content. This CL enables multidexing for a few targets that fail building when we stop pre-proguarding the play services library BUG=668211 Committed: https://crrev.com/a2515b11698058cef320f53ec4df844a2b558d06 Cr-Commit-Position: refs/heads/master@{#437593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M android_webview/test/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M blimp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
dgn
PTAL I removed the current downstream intermediate proguarding and ran `ninja -C out_android_gn/Debug all`, then ...
4 years ago (2016-12-08 14:31:47 UTC) #4
dgn
nyquist@chromium.org: Please review changes in //blimp torne@chromium.org: Please review changes in //android_webview
4 years ago (2016-12-08 15:41:48 UTC) #6
Torne
android_webview lgtm
4 years ago (2016-12-08 15:45:28 UTC) #7
nyquist
blimp lgtm
4 years ago (2016-12-08 16:30:54 UTC) #10
dgn
sdefresne@chromium.org: Please review changes in components/BUILD.gn
4 years ago (2016-12-08 17:38:36 UTC) #12
dgn
Thanks, I will land it tomorrow morning when I have time to watch the bots.
4 years ago (2016-12-08 17:39:23 UTC) #13
agrieve
lgtm. I think it's fine for now, and we'll see if other targets start hitting ...
4 years ago (2016-12-09 15:44:05 UTC) #15
blundell
rubberstamp lgtm for //components
4 years ago (2016-12-09 16:52:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563663002/1
4 years ago (2016-12-09 17:11:31 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 18:41:19 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-12 14:36:26 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2515b11698058cef320f53ec4df844a2b558d06
Cr-Commit-Position: refs/heads/master@{#437593}

Powered by Google App Engine
This is Rietveld 408576698