Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2563613004: Deflake http/tests/inspector/tracing/timeline-receive-response-event.html (Closed)

Created:
4 years ago by yhirano
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake http/tests/inspector/tracing/timeline-receive-response-event.html As a follow-up for [1], this CL fixes the flakiness of timeline-receive-response-event.html by dumping only the first ResourceReceivedData event for each request. 1: https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79 BUG=666217 Committed: https://crrev.com/4abbfe190c2692147bcea746c5cadc3d13b979a8 Cr-Commit-Position: refs/heads/master@{#437810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-receive-response-event.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-receive-response-event-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yhirano
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=timeline-receive-response-event.html looks flaky. As promised in the previous CL, I'm fixing the flakiness.
4 years ago (2016-12-09 11:04:17 UTC) #4
dgozman
Thank you! lgtm
4 years ago (2016-12-09 21:03:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563613004/1
4 years ago (2016-12-12 00:46:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 01:49:24 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 15:10:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4abbfe190c2692147bcea746c5cadc3d13b979a8
Cr-Commit-Position: refs/heads/master@{#437810}

Powered by Google App Engine
This is Rietveld 408576698