Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2563593003: [Mac] RTL-aware rendering for BubbleDecoration and SecurityStateBubbleDecoration (Closed)

Created:
4 years ago by lgrey
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] RTL-aware rendering for BubbleDecoration and SecurityStateBubbleDecoration This is almost the same exact code, so it might be worthwhile to find a way to abstract it out, but I think it's probably not in scope for this CL. BUG=648557 Committed: https://crrev.com/36c124b2f291fb5ccafab387f59d3b3b9948422f Cr-Commit-Position: refs/heads/master@{#437631}

Patch Set 1 #

Patch Set 2 : Style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -18 lines) Patch
M chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm View 1 4 chunks +23 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm View 1 8 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
lgrey
PTAL :)
4 years ago (2016-12-08 19:25:12 UTC) #2
Elly Fong-Jones
lgtm
4 years ago (2016-12-09 19:02:19 UTC) #3
lgrey
Thanks! Mark PTAL for OWNERS
4 years ago (2016-12-09 19:04:58 UTC) #5
Mark Mentovai
LGTM
4 years ago (2016-12-09 19:05:50 UTC) #6
lgrey
Thanks!
4 years ago (2016-12-09 19:06:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563593003/20001
4 years ago (2016-12-09 19:07:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 20:39:59 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/36c124b2f291fb5ccafab387f59d3b3b9948422f Cr-Commit-Position: refs/heads/master@{#437631}
4 years ago (2016-12-12 14:40:06 UTC) #14
Avi (use Gerrit)
3 years, 10 months ago (2017-02-17 01:57:22 UTC) #15
Message was sent while issue was closed.
On 2016/12/12 14:40:06, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/36c124b2f291fb5ccafab387f59d3b3b9948422f
> Cr-Commit-Position: refs/heads/master@{#437631}

FYI this doesn't seem to actually work. Filed http://crbug.com/693303

Powered by Google App Engine
This is Rietveld 408576698