Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2563583002: Revert of ServiceWorker: Change DCHECK to CHECK for debugging process allocation (Closed)

Created:
4 years ago by shimazu
Modified:
4 years ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ServiceWorker: Change DCHECK to CHECK for debugging process allocation (patchset #1 id:1 of https://codereview.chromium.org/2528333002/ ) Reason for revert: There was no crash came from this CHECK. Original issue's description: > ServiceWorker: Change DCHECK to CHECK for debugging process allocation > > This patch is to confirm if the process allocation works well. > > BUG=668633 > > Committed: https://crrev.com/21c5638d913d1147a0a3e6a69c69ebe9bfa993bb > Cr-Commit-Position: refs/heads/master@{#434628} TBR=falken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=668633 Committed: https://crrev.com/5ba32e3b076282184f9502db3559f122cb0d2ac1 Cr-Commit-Position: refs/heads/master@{#437839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/browser/service_worker/embedded_worker_instance.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
shimazu
Created Revert of ServiceWorker: Change DCHECK to CHECK for debugging process allocation
4 years ago (2016-12-08 05:06:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563583002/1
4 years ago (2016-12-08 05:06:16 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82006)
4 years ago (2016-12-08 06:23:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563583002/1
4 years ago (2016-12-12 05:57:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/196895)
4 years ago (2016-12-12 07:19:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563583002/1
4 years ago (2016-12-12 08:22:22 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 09:57:35 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-12 15:11:16 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ba32e3b076282184f9502db3559f122cb0d2ac1
Cr-Commit-Position: refs/heads/master@{#437839}

Powered by Google App Engine
This is Rietveld 408576698