Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2563523002:
Delete AutofillAddressTest (Closed)
|
Created:
4 years ago by please use gerrit instead Modified:
3 years, 11 months ago Reviewers:
Ian Wen CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDelete AutofillAddressTest
The file was never added to the build and is now hopelessly out of date.
Other parts of the code exercise AutofillAddress sufficiently anyway.
BUG=672196
Review-Url: https://codereview.chromium.org/2563523002
Cr-Commit-Position: refs/heads/master@{#441934}
Committed: https://chromium.googlesource.com/chromium/src/+/d3f91633a7bad0370800470d8ea76078b1ac02db
Patch Set 1 #Patch Set 2 #Patch Set 3 #Messages
Total messages: 22 (18 generated)
The CQ bit was checked by rouslan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by rouslan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== Add AutofillAddressTest to the build BUG=672196 ========== to ========== Delete AutofillAddressTest The file was never added to the build and is now hopelessly out of date. Other parts of the code exercise AutofillAddress sufficiently anyway. BUG=672196 ==========
The CQ bit was checked by rouslan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Delete AutofillAddressTest The file was never added to the build and is now hopelessly out of date. Other parts of the code exercise AutofillAddress sufficiently anyway. BUG=672196 ========== to ========== Delete AutofillAddressTest The file was never added to the build and is now hopelessly out of date. Other parts of the code exercise AutofillAddress sufficiently anyway. BUG=672196 ==========
rouslan@chromium.org changed reviewers: + ianwen@chromium.org
ianwen, ptal.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm. May it rest in peace.
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483713397469980,
"parent_rev": "cb48fcfad8b0f6de386bb5d45bfc1090b1601f8b", "commit_rev":
"d3f91633a7bad0370800470d8ea76078b1ac02db"}
Message was sent while issue was closed.
Description was changed from ========== Delete AutofillAddressTest The file was never added to the build and is now hopelessly out of date. Other parts of the code exercise AutofillAddress sufficiently anyway. BUG=672196 ========== to ========== Delete AutofillAddressTest The file was never added to the build and is now hopelessly out of date. Other parts of the code exercise AutofillAddress sufficiently anyway. BUG=672196 Review-Url: https://codereview.chromium.org/2563523002 Cr-Commit-Position: refs/heads/master@{#441934} Committed: https://chromium.googlesource.com/chromium/src/+/d3f91633a7bad0370800470d8ea7... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d3f91633a7bad0370800470d8ea7... |
