Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: components/previews/core/previews_black_list.h

Issue 2563493002: Disallow showing offline previews on a reload. (Closed)
Patch Set: testing Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/previews/core/previews_black_list.h
diff --git a/components/previews/core/previews_black_list.h b/components/previews/core/previews_black_list.h
index e9151da625cf736a358f815ace26af04524eb465..6abac75b2e7506984d6bddd1c111d0c98cf1c426 100644
--- a/components/previews/core/previews_black_list.h
+++ b/components/previews/core/previews_black_list.h
@@ -49,7 +49,9 @@ enum class PreviewsEligibilityReason {
NETWORK_QUALITY_UNAVAILABLE = 6,
// The network was fast enough to not warrant previews.
NETWORK_NOT_SLOW = 7,
- LAST = 8,
+ // If the page was reloaded, the user should not be shown an offline preview.
tbansal1 2016/12/12 19:52:21 Should the user be shown the offline page if they
RyanSturm 2016/12/12 22:42:15 This isn't the offline pages so much as offline pr
+ RELOAD_DISALLOWED_FOR_OFFLINE = 8,
+ LAST = 9,
};
// Manages the state of black listed domains for the previews experiment. Loads
« no previous file with comments | « no previous file | components/previews/core/previews_io_data.cc » ('j') | components/previews/core/previews_io_data.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698