Disallow showing offline previews on a reload.

components/previews/core/previews_black_list.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PREVIEWS_CORE_PREVIEWS_BLACK_LIST_H_
 #define COMPONENTS_PREVIEWS_CORE_PREVIEWS_BLACK_LIST_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 31 matching lines @@
   // The user has opted out of previews often, and is no longer shown previews
   // on any host.
   USER_BLACKLISTED = 4,
   // The user has opted out of previews on a specific host often, and was not
   // not shown a previews on that host.
   HOST_BLACKLISTED = 5,
   // The network quality estimate is not available.
   NETWORK_QUALITY_UNAVAILABLE = 6,
   // The network was fast enough to not warrant previews.
   NETWORK_NOT_SLOW = 7,
-  LAST = 8,
+  // If the page was reloaded, the user should not be shown an offline preview.

[tbansal1, 2016/12/12 19:52:21]

Should the user be shown the offline page if they are still offline after the
reload?

[RyanSturm, 2016/12/12 22:42:15]

This isn't the offline pages so much as offline previews. If the user reloads,
if they are offline, they will still be shown an offline page due to the normal
offline page logic.

+  RELOAD_DISALLOWED_FOR_OFFLINE = 8,
+  LAST = 9,
 };
 
 // Manages the state of black listed domains for the previews experiment. Loads
 // the stored black list from |opt_out_store| and manages an in memory black
 // list on the IO thread. Updates to the black list are stored in memory and
 // pushed to the store. Asynchronous modifications are stored in a queue and
 // executed in order. Reading from the black list is always synchronous, and if
 // the black list is not currently loaded (e.g., at startup, after clearing
 // browsing history), domains are reported as black listed. The list stores no
 // more than previews::params::MaxInMemoryHostsInBlackList hosts in-memory,
@@ skipping 85 matching lines @@
   base::ThreadChecker thread_checker_;
 
   base::WeakPtrFactory<PreviewsBlackList> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PreviewsBlackList);
 };
 
 }  // namespace previews
 
 #endif  // COMPONENTS_PREVIEWS_CORE_PREVIEWS_BLACK_LIST_H_