Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2563443005:
MD Settings: Make links inside disabled checkbox clickable on syncSetup page (Closed)
|
Created:
4 years ago by scottchen Modified:
4 years ago Reviewers:
dpapad CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Make links inside disabled checkbox clickable on syncSetup page
BUG=621903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/d93ce395d082047e5b0d5d4ef038eeb3106beb22
Cr-Commit-Position: refs/heads/master@{#437597}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 19 (12 generated)
Description was changed from ========== MD Settings: make links inside disabled checkbox label clickable BUG=621903 ========== to ========== MD Settings: make links inside disabled checkbox label clickable BUG=621903 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
scottchen@chromium.org changed reviewers: + dpapad@chromium.org
CL description makes it sound that you are adding a generic fix, but this only fixes one occurrence. Let's just mention "sync page" somewhere in the description. LGTM https://codereview.chromium.org/2563443005/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/people_page/sync_page.html (right): https://codereview.chromium.org/2563443005/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/people_page/sync_page.html:48: #paymentLearnMore { Perhaps add a comment explaining why this is necessary, something like ('A disabled paper-checkbox prevents tapping on a link'). And if you end-up filing a Polymer bug, add a link to the bug too in the comment.
The CQ bit was checked by scottchen@chromium.org to run a CQ dry run
Description was changed from ========== MD Settings: make links inside disabled checkbox label clickable BUG=621903 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Make links inside disabled checkbox clickable on syncSetup page BUG=621903 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by scottchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481308424477030, "parent_rev":
"81986847a4173f5b3bbd9c49cd91619a9b66b7f5", "commit_rev":
"8434bba588e285d8a2d0f8442cb6e0ae39c3c20f"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Make links inside disabled checkbox clickable on syncSetup page BUG=621903 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Make links inside disabled checkbox clickable on syncSetup page BUG=621903 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2563443005 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
https://codereview.chromium.org/2563443005/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/people_page/sync_page.html (right): https://codereview.chromium.org/2563443005/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/people_page/sync_page.html:48: #paymentLearnMore { On 2016/12/09 00:56:09, dpapad wrote: > Perhaps add a comment explaining why this is necessary, something like ('A > disabled paper-checkbox prevents tapping on a link'). And if you end-up filing a > Polymer bug, add a link to the bug too in the comment. Acknowledged.
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2567753002/ by scottchen@chromium.org. The reason for reverting is: Meant to create a new CL.
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Make links inside disabled checkbox clickable on syncSetup page BUG=621903 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2563443005 ========== to ========== MD Settings: Make links inside disabled checkbox clickable on syncSetup page BUG=621903 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d93ce395d082047e5b0d5d4ef038eeb3106beb22 Cr-Commit-Position: refs/heads/master@{#437597} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d93ce395d082047e5b0d5d4ef038eeb3106beb22 Cr-Commit-Position: refs/heads/master@{#437597} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
