Always send a fail or finish notification for each navigation.

third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp

Index: third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp b/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
index cf60f794230812462c0af56b947fc3e7bb982446..0e76d24655733aa96881966f26f2e2020cd091dc 100644
--- a/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
@@ -87,11 +87,8 @@ class BaseAudioContextTest : public ::testing::Test {
   }
 
   void TearDown() override {
-    if (m_childFrame) {
-      m_childDocumentLoader->detachFromFrame();
-      m_childDocumentLoader.clear();

[dcheng, 2016/12/14 23:01:28]

Yay, simplification.

+    if (m_childFrame)
       m_childFrame->detach(FrameDetachType::Remove);
-    }
   }
 
   void createChildFrame() {
@@ -100,9 +97,6 @@ class BaseAudioContextTest : public ::testing::Test {
         document().frame()->host(), m_dummyFrameOwner.get());
     m_childFrame->setView(FrameView::create(*m_childFrame, IntSize(500, 500)));
     m_childFrame->init();
-    m_childDocumentLoader = DocumentLoader::create(

[Nate Chapin, 2016/12/12 21:40:38]

This DocumentLoader isn't fully attached to the frame, and dies in loadFailed()
during teardown. This test works just fine using the initial DocumentLoader
created in init().

-        m_childFrame.get(), ResourceRequest("https://www.example.com"),
-        SubstituteData(), ClientRedirectPolicy::NotClientRedirect);
 
     childDocument().updateSecurityOrigin(
         SecurityOrigin::create("https", "cross-origin.com", 80));
@@ -129,7 +123,6 @@ class BaseAudioContextTest : public ::testing::Test {
   Persistent<DummyFrameOwner> m_dummyFrameOwner;
 
   Persistent<LocalFrame> m_childFrame;
-  Persistent<DocumentLoader> m_childDocumentLoader;
 
   BaseAudioContextTestPlatform m_testPlatform;
 };