Always send a fail or finish notification for each navigation.

third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/webaudio/BaseAudioContext.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/DocumentUserGestureToken.h"
 #include "core/frame/FrameOwner.h"
 #include "core/frame/FrameTypes.h"
@@ skipping 69 matching lines @@
   using AutoplayStatus = BaseAudioContext::AutoplayStatus;
 
   void SetUp() override {
     m_dummyPageHolder = DummyPageHolder::create();
     m_dummyFrameOwner = DummyFrameOwner::create();
     document().updateSecurityOrigin(
         SecurityOrigin::create("https", "example.com", 80));
   }
 
   void TearDown() override {
-    if (m_childFrame) {
-      m_childDocumentLoader->detachFromFrame();
-      m_childDocumentLoader.clear();

[dcheng, 2016/12/14 23:01:28]

Yay, simplification.

+    if (m_childFrame)
       m_childFrame->detach(FrameDetachType::Remove);
-    }
   }
 
   void createChildFrame() {
     m_childFrame = LocalFrame::create(
         MockCrossOriginFrameLoaderClient::create(document().frame()),
         document().frame()->host(), m_dummyFrameOwner.get());
     m_childFrame->setView(FrameView::create(*m_childFrame, IntSize(500, 500)));
     m_childFrame->init();
-    m_childDocumentLoader = DocumentLoader::create(

[Nate Chapin, 2016/12/12 21:40:38]

This DocumentLoader isn't fully attached to the frame, and dies in loadFailed()
during teardown. This test works just fine using the initial DocumentLoader
created in init().

-        m_childFrame.get(), ResourceRequest("https://www.example.com"),
-        SubstituteData(), ClientRedirectPolicy::NotClientRedirect);
 
     childDocument().updateSecurityOrigin(
         SecurityOrigin::create("https", "cross-origin.com", 80));
   }
 
   Document& document() { return m_dummyPageHolder->document(); }
 
   Document& childDocument() { return *m_childFrame->document(); }
 
   ScriptState* getScriptStateFrom(const Document& document) {
     return ScriptState::forMainWorld(document.frame());
   }
 
   void rejectPendingResolvers(BaseAudioContext* audioContext) {
     audioContext->rejectPendingResolvers();
   }
 
   void recordAutoplayStatus(BaseAudioContext* audioContext) {
     audioContext->recordAutoplayStatus();
   }
 
  private:
   std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
   Persistent<DummyFrameOwner> m_dummyFrameOwner;
 
   Persistent<LocalFrame> m_childFrame;
-  Persistent<DocumentLoader> m_childDocumentLoader;
 
   BaseAudioContextTestPlatform m_testPlatform;
 };
 
 TEST_F(BaseAudioContextTest, AutoplayMetrics_NoRestriction) {
   HistogramTester histogramTester;
 
   BaseAudioContext* audioContext =
       BaseAudioContext::create(document(), ASSERT_NO_EXCEPTION);
   recordAutoplayStatus(audioContext);
@@ skipping 143 matching lines @@
   audioContext->resumeContext(getScriptStateFrom(childDocument()));
   rejectPendingResolvers(audioContext);
   recordAutoplayStatus(audioContext);
 
   histogramTester.expectBucketCount(kCrossOriginMetric,
                                     AutoplayStatus::AutoplayStatusSucceeded, 1);
   histogramTester.expectTotalCount(kCrossOriginMetric, 1);
 }
 
 }  // namespace blink