Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2563353002: Generate storage for -webkit-box-direction in ComputedStyleBase (Closed)

Created:
4 years ago by sashab
Modified:
4 years ago
Reviewers:
napper, rjwright, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate storage for -webkit-box-direction in ComputedStyleBase Moved the inherited property -webkit-box-direction and its enum, EBoxDirection, to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/79511bbcbf12f6d3bb2b32ae7d1ead9a679e6a21 Cr-Commit-Position: refs/heads/master@{#438368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 4 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
sashab
Sorry, lots of reviews today :) All little ones
4 years ago (2016-12-12 03:52:57 UTC) #4
napper
lgtm
4 years ago (2016-12-12 03:55:47 UTC) #5
sashab
rjwright@ rs please :)
4 years ago (2016-12-12 03:59:35 UTC) #7
sashab
ping renee
4 years ago (2016-12-13 01:50:00 UTC) #10
rune
lgtm
4 years ago (2016-12-13 08:50:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563353002/1
4 years ago (2016-12-13 23:15:46 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 00:56:29 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-14 00:58:49 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79511bbcbf12f6d3bb2b32ae7d1ead9a679e6a21
Cr-Commit-Position: refs/heads/master@{#438368}

Powered by Google App Engine
This is Rietveld 408576698