Remove extension_misc::IsImeMenuExtensionId.

Remove extension_misc::IsImeMenuExtensionId.

extension_misc::IsImeMenuExtensionId() is added for some opt-in IME menu specific logic, since we used to used IME extensions to show the menu:

1) extension_launcher_context_menu.cc: Remove close button from context menu (see issue 1611463002).
2) chrome_native_app_window_views.cc: Move IME menu from mru list (see issue 2025263002).

Since we have abandoned the way of using IME extensions to show IME menu, all these codes could be removed.

BUG=670825
TEST=Verified on local build.

Committed: https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38
Cr-Commit-Position: refs/heads/master@{#438382}

[Azure Wei, 2016-12-12 02:16:51]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 02:17:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 03:01:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 03:01:43]

Dry run: This issue passed the CQ dry run.

[Azure Wei, 2016-12-12 06:33:14]

Description was changed from

==========
Remove extension_misc::IsImeMenuExtensionId.


Request focus on IME property row after keyboard selection.

BUG=670825
TEST=Verified on local build.
==========

to

==========
Remove extension_misc::IsImeMenuExtensionId.

extension_misc::IsImeMenuExtensionId() is added for some opt-in IME menu
specific logic, since we used to used IME extensions to show the menu:

1) extension_launcher_context_menu.cc: Remove close button from context menu
(see issue 1611463002).
2) chrome_native_app_window_views.cc: Move IME menu from mru list (see issue
2025263002).

Since we have abandoned the way of using IME extensions to show IME menu, all
these codes could be removed. 


BUG=670825
TEST=Verified on local build.
==========

[Azure Wei, 2016-12-12 06:33:14]

azurewei@chromium.org changed reviewers:
+ sky@chromium.org

[Azure Wei, 2016-12-12 06:35:35]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 06:35:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 07:19:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 07:20:00]

Dry run: This issue passed the CQ dry run.

[Azure Wei, 2016-12-12 08:12:35]

Please review this CL. Thanks!

[sky, 2016-12-12 16:06:55]

Make sure you also cleanup any stale includes.

https://codereview.chromium.org/2563343002/diff/20001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc (right):

https://codereview.chromium.org/2563343002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc:56: if
(controller()->IsOpen(item().id)) {
remove {}

https://codereview.chromium.org/2563343002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc:97: if
(controller()->IsOpen(item().id)) {
remove {}

https://codereview.chromium.org/2563343002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/chrome_native_app_window_views.cc (left):

https://codereview.chromium.org/2563343002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:236:
widget()->GetNativeView()->SetProperty(aura::client::kExcludeFromMruKey,
Can kExcludeFromMruKey be removed now?

https://codereview.chromium.org/2563343002/diff/20001/chrome/common/extension...
File chrome/common/extensions/extension_constants.h (right):

https://codereview.chromium.org/2563343002/diff/20001/chrome/common/extension...
chrome/common/extensions/extension_constants.h:10: #include <string>
remove include

[Azure Wei, 2016-12-12 23:51:51]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 23:53:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:43:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Azure Wei, 2016-12-13 08:31:17]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 08:31:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 09:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 09:15:28]

Dry run: This issue passed the CQ dry run.

[Azure Wei, 2016-12-13 11:20:47]

https://codereview.chromium.org/2563343002/diff/20001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc (right):

https://codereview.chromium.org/2563343002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc:56: if
(controller()->IsOpen(item().id)) {
On 2016/12/12 16:06:55, sky wrote:
> remove {}

Done.

https://codereview.chromium.org/2563343002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc:97: if
(controller()->IsOpen(item().id)) {
On 2016/12/12 16:06:55, sky wrote:
> remove {}

Done.

https://codereview.chromium.org/2563343002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/chrome_native_app_window_views.cc (left):

https://codereview.chromium.org/2563343002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:236:
widget()->GetNativeView()->SetProperty(aura::client::kExcludeFromMruKey,
On 2016/12/12 16:06:55, sky wrote:
> Can kExcludeFromMruKey be removed now?

Removed.

https://codereview.chromium.org/2563343002/diff/20001/chrome/common/extension...
File chrome/common/extensions/extension_constants.h (right):

https://codereview.chromium.org/2563343002/diff/20001/chrome/common/extension...
chrome/common/extensions/extension_constants.h:10: #include <string>
On 2016/12/12 16:06:55, sky wrote:
> remove include

Done.

[sky, 2016-12-13 14:14:02]

Nice! LGTM

[Azure Wei, 2016-12-14 00:42:16]

The CQ bit was checked by azurewei@chromium.org

[commit-bot: I haz the power, 2016-12-14 00:43:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:38:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481676136188830,
"parent_rev": "ef90340ff39466bbd5b0f13a48f74235c3807872", "commit_rev":
"06ba3c8ad07ea54f809f82b503156fdee0f4410e"}

[commit-bot: I haz the power, 2016-12-14 01:39:20]

Description was changed from

==========
Remove extension_misc::IsImeMenuExtensionId.

extension_misc::IsImeMenuExtensionId() is added for some opt-in IME menu
specific logic, since we used to used IME extensions to show the menu:

1) extension_launcher_context_menu.cc: Remove close button from context menu
(see issue 1611463002).
2) chrome_native_app_window_views.cc: Move IME menu from mru list (see issue
2025263002).

Since we have abandoned the way of using IME extensions to show IME menu, all
these codes could be removed. 


BUG=670825
TEST=Verified on local build.
==========

to

==========
Remove extension_misc::IsImeMenuExtensionId.

extension_misc::IsImeMenuExtensionId() is added for some opt-in IME menu
specific logic, since we used to used IME extensions to show the menu:

1) extension_launcher_context_menu.cc: Remove close button from context menu
(see issue 1611463002).
2) chrome_native_app_window_views.cc: Move IME menu from mru list (see issue
2025263002).

Since we have abandoned the way of using IME extensions to show IME menu, all
these codes could be removed. 


BUG=670825
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2563343002
==========

[commit-bot: I haz the power, 2016-12-14 01:39:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-14 01:44:01]

Description was changed from

==========
Remove extension_misc::IsImeMenuExtensionId.

extension_misc::IsImeMenuExtensionId() is added for some opt-in IME menu
specific logic, since we used to used IME extensions to show the menu:

1) extension_launcher_context_menu.cc: Remove close button from context menu
(see issue 1611463002).
2) chrome_native_app_window_views.cc: Move IME menu from mru list (see issue
2025263002).

Since we have abandoned the way of using IME extensions to show IME menu, all
these codes could be removed. 


BUG=670825
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2563343002
==========

to

==========
Remove extension_misc::IsImeMenuExtensionId.

extension_misc::IsImeMenuExtensionId() is added for some opt-in IME menu
specific logic, since we used to used IME extensions to show the menu:

1) extension_launcher_context_menu.cc: Remove close button from context menu
(see issue 1611463002).
2) chrome_native_app_window_views.cc: Move IME menu from mru list (see issue
2025263002).

Since we have abandoned the way of using IME extensions to show IME menu, all
these codes could be removed.

BUG=670825
TEST=Verified on local build.

Committed: https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38
Cr-Commit-Position: refs/heads/master@{#438382}
==========

[commit-bot: I haz the power, 2016-12-14 01:44:02]

Patchset 3 (id:??) landed as
https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38
Cr-Commit-Position: refs/heads/master@{#438382}