Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 256333003: Revert of Password bubble: Introduce a command to open the bubble. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Revert of Password bubble: Introduce a command to open the bubble. (https://codereview.chromium.org/246393004/) Reason for revert: This is causing leaks on linux asan lsan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/2361 Original issue's description: > Password bubble: ManagePasswordsIconView is now a BubbleIconView. > > This CL introduces a new browser command to open the Manage Passwords bubble, > and converts the ManagePasswordsIconView class into a subclass of > BubbleIconView, which uses the new command to control the bubble's state. > This allows us to more easily test the view and the UI controller, as each > object's job is now more clearly defined (and the view is now doing a good > deal less work), and to independently verify that the command is doing the > right thing. > > After this CL, we'll (finally!) have something approaching reasonable test > coverage for the core of the views code. > > BUG=365678 > TBR=cpu@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266859 TBR=markusheintz@chromium.org,vabr@chromium.org,cpu@chromium.org,pkasting@chromium.org,mkwst@chromium.org NOTREECHECKS=true NOTRY=true BUG=365678 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -420 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_icon.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_icon.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_icon_mock.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_icon_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 2 chunks +0 lines, -18 lines 0 comments Download
D chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_icon_view.h View 1 chunk +11 lines, -29 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc View 3 chunks +46 lines, -32 lines 0 comments Download
D chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/views/passwords/manage_passwords_view_test.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/ui/views/passwords/manage_passwords_view_test.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
Created Revert of Password bubble: Introduce a command to open the bubble.
6 years, 7 months ago (2014-04-29 13:10:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/256333003/1
6 years, 7 months ago (2014-04-29 13:10:45 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 13:11:33 UTC) #3
Message was sent while issue was closed.
Change committed as 266862

Powered by Google App Engine
This is Rietveld 408576698