DescriptionRevert of Password bubble: Introduce a command to open the bubble. (https://codereview.chromium.org/246393004/)
Reason for revert:
This is causing leaks on linux asan lsan:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/2361
Original issue's description:
> Password bubble: ManagePasswordsIconView is now a BubbleIconView.
>
> This CL introduces a new browser command to open the Manage Passwords bubble,
> and converts the ManagePasswordsIconView class into a subclass of
> BubbleIconView, which uses the new command to control the bubble's state.
> This allows us to more easily test the view and the UI controller, as each
> object's job is now more clearly defined (and the view is now doing a good
> deal less work), and to independently verify that the command is doing the
> right thing.
>
> After this CL, we'll (finally!) have something approaching reasonable test
> coverage for the core of the views code.
>
> BUG=365678
> TBR=cpu@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266859
TBR=markusheintz@chromium.org,vabr@chromium.org,cpu@chromium.org,pkasting@chromium.org,mkwst@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=365678
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266862
Patch Set 1 #
Created: 6 years, 7 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|