chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc - Issue 256333003: Revert of Password bubble: Introduce a command to open the bubble.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

Issue 256333003: Revert of Password bubble: Introduce a command to open the bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/browser_dialogs.h ('k') | chrome/browser/ui/passwords/manage_passwords_icon.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"	5 #include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"

6	6

7 #include "chrome/browser/chrome_notification_types.h"	7 #include "chrome/browser/chrome_notification_types.h"

8 #include "chrome/browser/password_manager/password_store_factory.h"	8 #include "chrome/browser/password_manager/password_store_factory.h"

9 #include "chrome/browser/ui/browser_finder.h"	9 #include "chrome/browser/ui/browser_finder.h"

10 #include "chrome/browser/ui/browser_window.h"	10 #include "chrome/browser/ui/browser_window.h"

(...skipping 152 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
163 state = ManagePasswordsIcon::BLACKLISTED_STATE;	163 state = ManagePasswordsIcon::BLACKLISTED_STATE;

164 else if (password_to_be_saved_)	164 else if (password_to_be_saved_)

165 state = ManagePasswordsIcon::PENDING_STATE;	165 state = ManagePasswordsIcon::PENDING_STATE;

166 else if (manage_passwords_icon_to_be_shown_)	166 else if (manage_passwords_icon_to_be_shown_)

167 state = ManagePasswordsIcon::MANAGE_STATE;	167 state = ManagePasswordsIcon::MANAGE_STATE;

168	168

169 icon->SetState(state);	169 icon->SetState(state);

170	170

171 if (manage_passwords_bubble_needs_showing_) {	171 if (manage_passwords_bubble_needs_showing_) {

172 DCHECK(state == ManagePasswordsIcon::PENDING_STATE);	172 DCHECK(state == ManagePasswordsIcon::PENDING_STATE);

173 // TODO(mkwst): Replace this with execution of a browser command once we

174 // can pipe a CommandUpdater down here.

175 icon->ShowBubbleWithoutUserInteraction();	173 icon->ShowBubbleWithoutUserInteraction();

176 manage_passwords_bubble_needs_showing_ = false;	174 manage_passwords_bubble_needs_showing_ = false;

177 }	175 }

178 }	176 }

OLD	NEW