Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2563263002: exo: Improve motion event synchronization. (Closed)

Created:
4 years ago by reveman
Modified:
4 years ago
Reviewers:
Daniele Castagna
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Improve motion event synchronization. This improves the synchronization by deferring the client side wait until commit time. BUG= TEST=wayland_motion_events Committed: https://crrev.com/f9ac10db3685a55ceac6105d9d3b8136f86b00b0 Cr-Commit-Position: refs/heads/master@{#437783}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -21 lines) Patch
M components/exo/wayland/clients/motion_events.cc View 1 8 chunks +38 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
reveman
4 years ago (2016-12-11 01:33:49 UTC) #2
Daniele Castagna
https://codereview.chromium.org/2563263002/diff/1/components/exo/wayland/clients/motion_events.cc File components/exo/wayland/clients/motion_events.cc (right): https://codereview.chromium.org/2563263002/diff/1/components/exo/wayland/clients/motion_events.cc#newcode691 components/exo/wayland/clients/motion_events.cc:691: if (buffer->egl_sync->is_valid()) { Can't egl_sync be nullptr? Should this ...
4 years ago (2016-12-11 01:44:15 UTC) #3
reveman
https://codereview.chromium.org/2563263002/diff/1/components/exo/wayland/clients/motion_events.cc File components/exo/wayland/clients/motion_events.cc (right): https://codereview.chromium.org/2563263002/diff/1/components/exo/wayland/clients/motion_events.cc#newcode691 components/exo/wayland/clients/motion_events.cc:691: if (buffer->egl_sync->is_valid()) { On 2016/12/11 at 01:44:15, Daniele Castagna ...
4 years ago (2016-12-11 01:50:51 UTC) #4
Daniele Castagna
lgtm
4 years ago (2016-12-11 01:52:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563263002/20001
4 years ago (2016-12-11 01:53:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-11 02:03:37 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-12 15:07:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9ac10db3685a55ceac6105d9d3b8136f86b00b0
Cr-Commit-Position: refs/heads/master@{#437783}

Powered by Google App Engine
This is Rietveld 408576698