Fix comment for kPasswordStore in chrome_switches.cc

Fix comment for kPasswordStore in chrome_switches.cc

The comment specified the purpose and possible values of the --password-store
switch. It was outdated in both respects. Since the proper implementation of
os_crypt on Linux earlier this year, the storage was used not just for
passwords, but also for os_crypt's encryption key.

This is even more problematic because the comment is picked up to generate
http://peter.sh/experiments/chromium-command-line-switches/.

This CL updates the description based on the relevant code in
components/os_crypt/key_storage_util_linux.cc.

The CL does not change the name of the flag on purpose: it is likely contained
in a lot of testing and developers' set-ups, and changing it could have
unwanted side-effects of testing data suddenly piling up in people's
Keyrings/KWallets. Once the alternative backends for Linux will stop being
used for storing passwords (https://crbug.com/571003), and only for the single
encryption key of os_crypt, it will be much safer to rename the switch.

BUG=673121
Committed: https://crrev.com/e19d5fabecf7bf77235fdf5db8350e3b0543d8fe
Cr-Commit-Position: refs/heads/master@{#437880}

[vabr (Chromium), 2016-12-10 20:22:44]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 20:23:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 21:05:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 21:05:08]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-12-12 06:58:55]

vabr@chromium.org changed reviewers:
+ msramek@chromium.org

[vabr (Chromium), 2016-12-12 06:58:56]

Hi Martin,

Please review.

Thanks!
Vaclav

[msramek, 2016-12-12 13:39:49]

LGTM (sorry for the delay, I overlooked the CL at first)

[vabr (Chromium), 2016-12-12 14:07:50]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-12-12 14:08:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-12-12 14:09:24]

On 2016/12/12 13:39:49, msramek wrote:
> LGTM (sorry for the delay, I overlooked the CL at first)

No problem at all. Not sure what you mean by "delay" either :). I only wish all
my CLs got reviewed within the same day, as this one did!

Cheers,
Vaclav

[commit-bot: I haz the power, 2016-12-12 15:50:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481551670003120, "parent_rev":
"cd792acde962d7dedca294317e291c00193aa46d", "commit_rev":
"597fb9e53681251262cbc7e9556b0fd2ac2e878a"}

[commit-bot: I haz the power, 2016-12-12 15:50:37]

Description was changed from

==========
Fix comment for kPasswordStore in chrome_switches.cc

The comment specified the purpose and possible values of the --password-store
switch. It was outdated in both respects. Since the proper implementation of
os_crypt on Linux earlier this year, the storage was used not just for
passwords, but also for os_crypt's encryption key.

This is even more problematic because the comment is picked up to generate
http://peter.sh/experiments/chromium-command-line-switches/.

This CL updates the description based on the relevant code in
components/os_crypt/key_storage_util_linux.cc.

The CL does not change the name of the flag on purpose: it is likely contained
in a lot of testing and developers' set-ups, and changing it could have
unwanted side-effects of testing data suddenly piling up in people's
Keyrings/KWallets. Once the alternative backends for Linux will stop being
used for storing passwords (https://crbug.com/571003), and only for the single
encryption key of os_crypt, it will be much safer to rename the switch.

BUG=673121
==========

to

==========
Fix comment for kPasswordStore in chrome_switches.cc

The comment specified the purpose and possible values of the --password-store
switch. It was outdated in both respects. Since the proper implementation of
os_crypt on Linux earlier this year, the storage was used not just for
passwords, but also for os_crypt's encryption key.

This is even more problematic because the comment is picked up to generate
http://peter.sh/experiments/chromium-command-line-switches/.

This CL updates the description based on the relevant code in
components/os_crypt/key_storage_util_linux.cc.

The CL does not change the name of the flag on purpose: it is likely contained
in a lot of testing and developers' set-ups, and changing it could have
unwanted side-effects of testing data suddenly piling up in people's
Keyrings/KWallets. Once the alternative backends for Linux will stop being
used for storing passwords (https://crbug.com/571003), and only for the single
encryption key of os_crypt, it will be much safer to rename the switch.

BUG=673121

Review-Url: https://codereview.chromium.org/2563253002
==========

[commit-bot: I haz the power, 2016-12-12 15:50:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 15:52:24]

Description was changed from

==========
Fix comment for kPasswordStore in chrome_switches.cc

The comment specified the purpose and possible values of the --password-store
switch. It was outdated in both respects. Since the proper implementation of
os_crypt on Linux earlier this year, the storage was used not just for
passwords, but also for os_crypt's encryption key.

This is even more problematic because the comment is picked up to generate
http://peter.sh/experiments/chromium-command-line-switches/.

This CL updates the description based on the relevant code in
components/os_crypt/key_storage_util_linux.cc.

The CL does not change the name of the flag on purpose: it is likely contained
in a lot of testing and developers' set-ups, and changing it could have
unwanted side-effects of testing data suddenly piling up in people's
Keyrings/KWallets. Once the alternative backends for Linux will stop being
used for storing passwords (https://crbug.com/571003), and only for the single
encryption key of os_crypt, it will be much safer to rename the switch.

BUG=673121

Review-Url: https://codereview.chromium.org/2563253002
==========

to

==========
Fix comment for kPasswordStore in chrome_switches.cc

The comment specified the purpose and possible values of the --password-store
switch. It was outdated in both respects. Since the proper implementation of
os_crypt on Linux earlier this year, the storage was used not just for
passwords, but also for os_crypt's encryption key.

This is even more problematic because the comment is picked up to generate
http://peter.sh/experiments/chromium-command-line-switches/.

This CL updates the description based on the relevant code in
components/os_crypt/key_storage_util_linux.cc.

The CL does not change the name of the flag on purpose: it is likely contained
in a lot of testing and developers' set-ups, and changing it could have
unwanted side-effects of testing data suddenly piling up in people's
Keyrings/KWallets. Once the alternative backends for Linux will stop being
used for storing passwords (https://crbug.com/571003), and only for the single
encryption key of os_crypt, it will be much safer to rename the switch.

BUG=673121

Committed: https://crrev.com/e19d5fabecf7bf77235fdf5db8350e3b0543d8fe
Cr-Commit-Position: refs/heads/master@{#437880}
==========

[commit-bot: I haz the power, 2016-12-12 15:52:25]

Patchset 1 (id:??) landed as
https://crrev.com/e19d5fabecf7bf77235fdf5db8350e3b0543d8fe
Cr-Commit-Position: refs/heads/master@{#437880}