Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2563173002: Fix issues with sending tts queue lots of utterances (Closed)

Created:
4 years ago by David Tseng
Modified:
4 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix issues with sending tts queue lots of utterances - $descendants for div's can be very expensive. For example, in Gmail, there is a focusable div that wraps almost the entire contents of the page. We end up generating Output for everything under the div and lag significantly when focus lands here. Fix this by only taking the text content of divs as one large string. $descendants had all output including rich formatting. - live region output on alerts causes double output (and similar lag). For example, pressing '?' in Gmail triggers hundreds of runs inside of LiveRegion. Fix this by ignoring live regions set on alert nodes. TEST=navigate in Gmail. BUG=672955 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a740f7ec72a6bf88e269f52c5561dd57ffde1589 Cr-Commit-Position: refs/heads/master@{#437925}

Patch Set 1 #

Patch Set 2 : Fix issues with sending tts queue lots of utterances #

Patch Set 3 : Fix issues with sending tts queue lots of utterances #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 5 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
David Tseng
4 years ago (2016-12-09 23:10:49 UTC) #3
dmazzoni
lgtm
4 years ago (2016-12-12 18:34:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563173002/40001
4 years ago (2016-12-12 19:13:07 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-12 22:08:43 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-12 22:10:36 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a740f7ec72a6bf88e269f52c5561dd57ffde1589
Cr-Commit-Position: refs/heads/master@{#437925}

Powered by Google App Engine
This is Rietveld 408576698