MD Settings: About: Fixes to channel switcher dialog

chrome/browser/resources/settings/about_page/channel_switcher_dialog.html

Index: chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
diff --git a/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html b/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
index a04b0f5abaf8a236460d108ba841f9411bbd804e..1edbba00f22670cb6af2c4580af4536fcac66295 100644
--- a/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
+++ b/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
@@ -9,7 +9,11 @@
 
 <dom-module id="settings-channel-switcher-dialog">
   <template>
-    <style include="settings-shared"></style>
+    <style include="settings-shared">
+      dialog {
+        width: 600px;
+      }
+    </style>
     <dialog is="cr-dialog" id="dialog">
       <div class="title">$i18n{aboutChangeChannel}</div>
       <div class="body">
@@ -19,13 +23,13 @@
         <paper-radio-group
             on-paper-radio-group-changed="onChannelSelectionChanged_">
           <paper-radio-button name="[[browserChannelEnum_.STABLE]]">
-            $i18n{aboutChannelStable}
+            $i18n{aboutChannelDialogStable}
           </paper-radio-button>
           <paper-radio-button name="[[browserChannelEnum_.BETA]]">
-            $i18n{aboutChannelBeta}
+            $i18n{aboutChannelDialogBeta}
           </paper-radio-button>
           <paper-radio-button name="[[browserChannelEnum_.DEV]]">
-            $i18n{aboutChannelDev}

[Dan Beam, 2016/12/14 03:41:02]

so wait... we want the new strings to differ from other parts of the code?

settings.browserChannelToI18nId uses the old I18n keys:
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_...

which is called by getUpdateStatusMessage_
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_...

do we want these UIs to match?

[stevenjb, 2016/12/14 19:42:36]

Those strings are inserted into a sentence:

https://cs.chromium.org/chromium/src/chrome/app/settings_strings.grdp?q=IDS_S...

We were being a bit lazy here and just using the lower case "stable", etc in the
dropdown also, instead of capitalized strings (with some extra text for dev):

https://cs.chromium.org/chromium/src/chrome/app/settings_strings.grdp?q=IDS_S...

+            $i18n{aboutChannelDialogDev}
           </paper-radio-button>
         </paper-radio-group>
         <div id="warning" hidden="[[!shouldShowWarning_(warning_)]]">