MD Settings: About: Fixes to channel switcher dialog

chrome/browser/resources/settings/about_page/channel_switcher_dialog.html

 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/paper-radio-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-group/paper-radio-group.html">
 <link rel="import" href="/about_page/about_page_browser_proxy.html">
 <link rel="import" href="/settings_shared_css.html">
 
 <dom-module id="settings-channel-switcher-dialog">
   <template>
-    <style include="settings-shared"></style>
+    <style include="settings-shared">
+      dialog {
+        width: 600px;
+      }
+    </style>
     <dialog is="cr-dialog" id="dialog">
       <div class="title">$i18n{aboutChangeChannel}</div>
       <div class="body">
         <!-- TODO(dbeam): this can be policy-controlled. Show this in the UI.
              https://www.chromium.org/administrators/policy-list-3#ChromeOsReleaseChannel
         -->
         <paper-radio-group
             on-paper-radio-group-changed="onChannelSelectionChanged_">
           <paper-radio-button name="[[browserChannelEnum_.STABLE]]">
-            $i18n{aboutChannelStable}
+            $i18n{aboutChannelDialogStable}
           </paper-radio-button>
           <paper-radio-button name="[[browserChannelEnum_.BETA]]">
-            $i18n{aboutChannelBeta}
+            $i18n{aboutChannelDialogBeta}
           </paper-radio-button>
           <paper-radio-button name="[[browserChannelEnum_.DEV]]">
-            $i18n{aboutChannelDev}

[Dan Beam, 2016/12/14 03:41:02]

so wait... we want the new strings to differ from other parts of the code?

settings.browserChannelToI18nId uses the old I18n keys:
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_...

which is called by getUpdateStatusMessage_
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_...

do we want these UIs to match?

[stevenjb, 2016/12/14 19:42:36]

Those strings are inserted into a sentence:

https://cs.chromium.org/chromium/src/chrome/app/settings_strings.grdp?q=IDS_S...

We were being a bit lazy here and just using the lower case "stable", etc in the
dropdown also, instead of capitalized strings (with some extra text for dev):

https://cs.chromium.org/chromium/src/chrome/app/settings_strings.grdp?q=IDS_S...

+            $i18n{aboutChannelDialogDev}
           </paper-radio-button>
         </paper-radio-group>
         <div id="warning" hidden="[[!shouldShowWarning_(warning_)]]">
           <h2>[[warning_.title]]</h2>
           <div>[[warning_.description]]</div>
         </div>
       </div>
       <div class="button-container">
         <paper-button class="cancel-button" on-tap="onCancelTap_"
             id="cancel">$i18n{cancel}</paper-button>
         <paper-button id="changeChannel" class="action-button"
             on-tap="onChangeChannelTap_"
             hidden="[[!shouldShowButtons_.changeChannel]]">
           $i18n{aboutChangeChannel}
         </paper-button>
         <paper-button id="changeChannelAndPowerwash" class="action-button"
             on-tap="onChangeChannelAndPowerwashTap_"
             hidden="[[!shouldShowButtons_.changeChannelAndPowerwash]]">
           $i18n{aboutChangeChannelAndPowerwash}
         </paper-button>
       </div>
     </dialog>
   </template>
   <script src="channel_switcher_dialog.js"></script>
 </dom-module>