Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2563073002:
[Chromecast] Add mock implementation of CastMetricsHelper. (Closed)
Description[Chromecast] Add mock implementation of CastMetricsHelper.
It will be used in multiple places to unit tests metrics recording,
so a separate file has been created rather than having every test
define its own.
BUG=internal b/33482814
Committed: https://crrev.com/a92f9f0c3d1ca66ace30de6190a0bd722cfc2cc6
Cr-Commit-Position: refs/heads/master@{#438036}
Patch Set 1 #
Messages
Total messages: 21 (8 generated)
esum@chromium.org changed reviewers: + gfhuang@chromium.org, halliwell@chromium.org
On 2016/12/09 16:55:49, esum wrote: lgtm, no bug number?
On 2016/12/09 16:58:23, gfhuang wrote: > On 2016/12/09 16:55:49, esum wrote: > > lgtm, no bug number? Not really a dedicated bug for this. It's miscellaneous cleanup I need to unit test something else. How does it work upstream again? Do I need to add BUG=none?
On 2016/12/09 17:01:34, esum wrote: > On 2016/12/09 16:58:23, gfhuang wrote: > > On 2016/12/09 16:55:49, esum wrote: > > > > lgtm, no bug number? > > Not really a dedicated bug for this. It's miscellaneous cleanup I need to unit > test something else. > > How does it work upstream again? Do I need to add BUG=none? you can create an internal bug and add BUG= internal b/xxxx
Description was changed from ========== [Chromecast] Add mock implementation of CastMetricsHelper. It will be used in multiple places to unit tests metrics recording, so a separate file has been created rather than having every test define its own. ========== to ========== [Chromecast] Add mock implementation of CastMetricsHelper. It will be used in multiple places to unit tests metrics recording, so a separate file has been created rather than having every test define its own. BUG=internal b/33482814 ==========
On 2016/12/09 17:13:42, gfhuang wrote: > On 2016/12/09 17:01:34, esum wrote: > > On 2016/12/09 16:58:23, gfhuang wrote: > > > On 2016/12/09 16:55:49, esum wrote: > > > > > > lgtm, no bug number? > > > > Not really a dedicated bug for this. It's miscellaneous cleanup I need to unit > > test something else. > > > > How does it work upstream again? Do I need to add BUG=none? > > you can create an internal bug and add BUG= internal b/xxxx Done.
On 2016/12/09 17:18:22, esum wrote: > On 2016/12/09 17:13:42, gfhuang wrote: > > On 2016/12/09 17:01:34, esum wrote: > > > On 2016/12/09 16:58:23, gfhuang wrote: > > > > On 2016/12/09 16:55:49, esum wrote: > > > > > > > > lgtm, no bug number? > > > > > > Not really a dedicated bug for this. It's miscellaneous cleanup I need to > unit > > > test something else. > > > > > > How does it work upstream again? Do I need to add BUG=none? > > > > you can create an internal bug and add BUG= internal b/xxxx > > Done. Friendly ping on this for owner's approval.
On 2016/12/12 19:24:13, esum wrote: > On 2016/12/09 17:18:22, esum wrote: > > On 2016/12/09 17:13:42, gfhuang wrote: > > > On 2016/12/09 17:01:34, esum wrote: > > > > On 2016/12/09 16:58:23, gfhuang wrote: > > > > > On 2016/12/09 16:55:49, esum wrote: > > > > > > > > > > lgtm, no bug number? > > > > > > > > Not really a dedicated bug for this. It's miscellaneous cleanup I need to > > unit > > > > test something else. > > > > > > > > How does it work upstream again? Do I need to add BUG=none? > > > > > > you can create an internal bug and add BUG= internal b/xxxx > > > > Done. > > Friendly ping on this for owner's approval. Sorry, this slipped through. lgtm
On 2016/12/12 21:05:35, halliwell wrote: > On 2016/12/12 19:24:13, esum wrote: > > On 2016/12/09 17:18:22, esum wrote: > > > On 2016/12/09 17:13:42, gfhuang wrote: > > > > On 2016/12/09 17:01:34, esum wrote: > > > > > On 2016/12/09 16:58:23, gfhuang wrote: > > > > > > On 2016/12/09 16:55:49, esum wrote: > > > > > > > > > > > > lgtm, no bug number? > > > > > > > > > > Not really a dedicated bug for this. It's miscellaneous cleanup I need > to > > > unit > > > > > test something else. > > > > > > > > > > How does it work upstream again? Do I need to add BUG=none? > > > > > > > > you can create an internal bug and add BUG= internal b/xxxx > > > > > > Done. > > > > Friendly ping on this for owner's approval. > > Sorry, this slipped through. lgtm No worries. Thank you!
The CQ bit was checked by esum@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by esum@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481595848196070, "parent_rev":
"444f557d086ab9bef5533aa0a2ed08dfb3592b95", "commit_rev":
"cfbf21a5745e1cb7d56ef2617ef513e3c743ed62"}
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] Add mock implementation of CastMetricsHelper. It will be used in multiple places to unit tests metrics recording, so a separate file has been created rather than having every test define its own. BUG=internal b/33482814 ========== to ========== [Chromecast] Add mock implementation of CastMetricsHelper. It will be used in multiple places to unit tests metrics recording, so a separate file has been created rather than having every test define its own. BUG=internal b/33482814 Review-Url: https://codereview.chromium.org/2563073002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] Add mock implementation of CastMetricsHelper. It will be used in multiple places to unit tests metrics recording, so a separate file has been created rather than having every test define its own. BUG=internal b/33482814 Review-Url: https://codereview.chromium.org/2563073002 ========== to ========== [Chromecast] Add mock implementation of CastMetricsHelper. It will be used in multiple places to unit tests metrics recording, so a separate file has been created rather than having every test define its own. BUG=internal b/33482814 Committed: https://crrev.com/a92f9f0c3d1ca66ace30de6190a0bd722cfc2cc6 Cr-Commit-Position: refs/heads/master@{#438036} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a92f9f0c3d1ca66ace30de6190a0bd722cfc2cc6 Cr-Commit-Position: refs/heads/master@{#438036} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
