Issue 256303007: Don't add code dependencies on transitioning stores eagerly.

Issue 256303007: Don't add code dependencies on transitioning stores eagerly. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer

Modified:
6 years, 7 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't add code dependencies on transitioning stores eagerly. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21110

Patch Set 1 : #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -25 lines)			Patch
M	src/arm/lithium-arm.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm64/lithium-arm64.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/arm64/lithium-arm64.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/handles.h	View	1 chunk	+7 lines, -0 lines	2 comments	Download
M	src/hydrogen.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	5 chunks	+4 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/lithium.h	View	3 chunks	+17 lines, -0 lines	0 comments	Download
M	src/lithium.cc	View	3 chunks	+16 lines, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/lithium-mips.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mvstanton

lgtm https://codereview.chromium.org/256303007/diff/20001/src/handles.h File src/handles.h (right): https://codereview.chromium.org/256303007/diff/20001/src/handles.h#newcode161 src/handles.h:161: return *lhs < *rhs; Seems like I see ...

6 years, 7 months ago (2014-05-02 06:34:15 UTC) #4

Benedikt Meurer

Committed patchset #1 manually as r21110 (presubmit successful).

6 years, 7 months ago (2014-05-02 06:38:09 UTC) #5

Benedikt Meurer

6 years, 7 months ago (2014-05-02 06:39:15 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/256303007/diff/20001/src/handles.h
File src/handles.h (right):

https://codereview.chromium.org/256303007/diff/20001/src/handles.h#newcode161
src/handles.h:161: return *lhs < *rhs;
Yeah... having some kind of ObjectTraits<T>::IsImmovable() would be nice, that
way we could add STATIC_ASSERT()s everywhere we depend on this...

Expand Messages | Collapse Messages