[perf-prof] fix crash when logging.

[perf-prof] fix crash when logging.

Logging for --perf-prof is not GC safe. Now, we are going to
emit source position info for optimized code when we are
profiling, logging, or debugging, and under the same condition,
pre-compute the line ends array for line number computation.

R=tebbi@chromium.org
BUG=v8:5730
Committed: https://crrev.com/75f5200508a779c51eafe99dd0ffe76858bffb27
Cr-Commit-Position: refs/heads/master@{#41619}

[Yang, 2016-12-09 10:36:10]

Description was changed from

==========
[perf-prof] fix crash when logging.

Logging for --perf-prof is not GC safe.

R=tebbi@chromium.org
BUG=v8:5730
==========

to

==========
[perf-prof] fix crash when logging.

Logging for --perf-prof is not GC safe. Now, we are going to
emit source position info for optimized code when we are
profiling, logging, or debugging, and under the same condition,
pre-compute the line ends array for line number computation.

R=tebbi@chromium.org
BUG=v8:5730
==========

[Tobias Tebbi, 2016-12-09 12:53:26]

lgtm

https://codereview.chromium.org/2562973002/diff/20001/src/perf-jit.cc
File src/perf-jit.cc (right):

https://codereview.chromium.org/2562973002/diff/20001/src/perf-jit.cc#newcode266
src/perf-jit.cc:266: ->ToCString(DISALLOW_NULLS, FAST_STRING_TRAVERSAL,
&name_length);
only ROBUST_STRING_TRAVERSAL seems to guarantee no GC

[Yang, 2016-12-09 14:00:36]

https://codereview.chromium.org/2562973002/diff/20001/src/perf-jit.cc
File src/perf-jit.cc (right):

https://codereview.chromium.org/2562973002/diff/20001/src/perf-jit.cc#newcode266
src/perf-jit.cc:266: ->ToCString(DISALLOW_NULLS, FAST_STRING_TRAVERSAL,
&name_length);
On 2016/12/09 12:53:26, Tobias Tebbi wrote:
> only ROBUST_STRING_TRAVERSAL seems to guarantee no GC

Not sure I understand. I don't think ToCString can trigger GC at all.
ROBUST_STRING_TRAVERSAL merely adds a check that the String is allocate on this
heap.

[Yang, 2016-12-09 14:00:50]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-12-09 14:00:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 14:30:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481292050898680,
"parent_rev": "4d530caf652f9e1ed2c525cf43e38457504da931", "commit_rev":
"99631caa652cddb4084ef9882b64b0a555849640"}

[commit-bot: I haz the power, 2016-12-09 14:30:10]

Description was changed from

==========
[perf-prof] fix crash when logging.

Logging for --perf-prof is not GC safe. Now, we are going to
emit source position info for optimized code when we are
profiling, logging, or debugging, and under the same condition,
pre-compute the line ends array for line number computation.

R=tebbi@chromium.org
BUG=v8:5730
==========

to

==========
[perf-prof] fix crash when logging.

Logging for --perf-prof is not GC safe. Now, we are going to
emit source position info for optimized code when we are
profiling, logging, or debugging, and under the same condition,
pre-compute the line ends array for line number computation.

R=tebbi@chromium.org
BUG=v8:5730

Review-Url: https://codereview.chromium.org/2562973002
==========

[commit-bot: I haz the power, 2016-12-09 14:30:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-09 14:30:46]

Description was changed from

==========
[perf-prof] fix crash when logging.

Logging for --perf-prof is not GC safe. Now, we are going to
emit source position info for optimized code when we are
profiling, logging, or debugging, and under the same condition,
pre-compute the line ends array for line number computation.

R=tebbi@chromium.org
BUG=v8:5730

Review-Url: https://codereview.chromium.org/2562973002
==========

to

==========
[perf-prof] fix crash when logging.

Logging for --perf-prof is not GC safe. Now, we are going to
emit source position info for optimized code when we are
profiling, logging, or debugging, and under the same condition,
pre-compute the line ends array for line number computation.

R=tebbi@chromium.org
BUG=v8:5730

Committed: https://crrev.com/75f5200508a779c51eafe99dd0ffe76858bffb27
Cr-Commit-Position: refs/heads/master@{#41619}
==========

[commit-bot: I haz the power, 2016-12-09 14:30:47]

Patchset 2 (id:??) landed as
https://crrev.com/75f5200508a779c51eafe99dd0ffe76858bffb27
Cr-Commit-Position: refs/heads/master@{#41619}