Fix DCHECK failure in extension_updater when scheduling first check

Fix DCHECK failure in extension_updater when scheduling first check

There's a DCHECK in ExtensionUpdater::ScheduleNextCheck that tries to
ensure we aren't scheduling the next check unreasonably soon (<= 1
second). But we serialize the "scheduled next check time" in prefs and
read that on next startup, and use it as long as it isn't in the past or
too far in the future, but if you get unlucky it can be < 1 second in
the future, and you'll hit this DCHECK.

BUG=654804
Committed: https://crrev.com/a94f63df7f0146e3532c22efb8e5468225e951c0
Cr-Commit-Position: refs/heads/master@{#438697}

[asargent_no_longer_on_chrome, 2016-12-09 22:13:40]

asargent@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2016-12-10 00:10:15]

lgtm

https://codereview.chromium.org/2562963003/diff/1/chrome/browser/extensions/u...
File chrome/browser/extensions/updater/extension_updater.cc (right):

https://codereview.chromium.org/2562963003/diff/1/chrome/browser/extensions/u...
chrome/browser/extensions/updater/extension_updater.cc:186: base::Time earliest
= now + TimeDelta::FromSeconds(1);
The value 1 is coming from  ExtensionUpdater::ScheduleNextCheck, right? I'd put
this in a constant in this file's anonymous namspace.

Also add a dcheck in the constructor to ensure frequence_seconds_ is greater
than this. It already checks for >= 5, but that value can change independently.

https://codereview.chromium.org/2562963003/diff/1/chrome/browser/extensions/u...
File chrome/browser/extensions/updater/extension_updater_unittest.cc (right):

https://codereview.chromium.org/2562963003/diff/1/chrome/browser/extensions/u...
chrome/browser/extensions/updater/extension_updater_unittest.cc:2274:
kDefaultUpdateFrequencySeconds, NULL,
nit: nullptr

[asargent_no_longer_on_chrome, 2016-12-14 23:01:20]

https://codereview.chromium.org/2562963003/diff/1/chrome/browser/extensions/u...
File chrome/browser/extensions/updater/extension_updater.cc (right):

https://codereview.chromium.org/2562963003/diff/1/chrome/browser/extensions/u...
chrome/browser/extensions/updater/extension_updater.cc:186: base::Time earliest
= now + TimeDelta::FromSeconds(1);
On 2016/12/10 00:10:15, lazyboy wrote:
> The value 1 is coming from  ExtensionUpdater::ScheduleNextCheck, right? I'd
put
> this in a constant in this file's anonymous namspace.
> 
> Also add a dcheck in the constructor to ensure frequence_seconds_ is greater
> than this. It already checks for >= 5, but that value can change
independently.

Done.

https://codereview.chromium.org/2562963003/diff/1/chrome/browser/extensions/u...
File chrome/browser/extensions/updater/extension_updater_unittest.cc (right):

https://codereview.chromium.org/2562963003/diff/1/chrome/browser/extensions/u...
chrome/browser/extensions/updater/extension_updater_unittest.cc:2274:
kDefaultUpdateFrequencySeconds, NULL,
On 2016/12/10 00:10:15, lazyboy wrote:
> nit: nullptr

Done.

[asargent_no_longer_on_chrome, 2016-12-14 23:01:24]

The CQ bit was checked by asargent@chromium.org

[asargent_no_longer_on_chrome, 2016-12-14 23:01:24]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2562963003/#ps20001
(title: "fix nits")

[commit-bot: I haz the power, 2016-12-14 23:02:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 01:16:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481756484483060,
"parent_rev": "90fb8b4bf5a5a626e73aa2c1c57cef66d539a542", "commit_rev":
"b462479efedc700e92f9bc70fe89e4d76f0afcac"}

[commit-bot: I haz the power, 2016-12-15 01:17:07]

Description was changed from

==========
Fix DCHECK failure in extension_updater when scheduling first check

There's a DCHECK in ExtensionUpdater::ScheduleNextCheck that tries to
ensure we aren't scheduling the next check unreasonably soon (<= 1
second). But we serialize the "scheduled next check time" in prefs and
read that on next startup, and use it as long as it isn't in the past or
too far in the future, but if you get unlucky it can be < 1 second in
the future, and you'll hit this DCHECK.


BUG=654804
==========

to

==========
Fix DCHECK failure in extension_updater when scheduling first check

There's a DCHECK in ExtensionUpdater::ScheduleNextCheck that tries to
ensure we aren't scheduling the next check unreasonably soon (<= 1
second). But we serialize the "scheduled next check time" in prefs and
read that on next startup, and use it as long as it isn't in the past or
too far in the future, but if you get unlucky it can be < 1 second in
the future, and you'll hit this DCHECK.


BUG=654804

Review-Url: https://codereview.chromium.org/2562963003
==========

[commit-bot: I haz the power, 2016-12-15 01:17:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-15 01:21:05]

Description was changed from

==========
Fix DCHECK failure in extension_updater when scheduling first check

There's a DCHECK in ExtensionUpdater::ScheduleNextCheck that tries to
ensure we aren't scheduling the next check unreasonably soon (<= 1
second). But we serialize the "scheduled next check time" in prefs and
read that on next startup, and use it as long as it isn't in the past or
too far in the future, but if you get unlucky it can be < 1 second in
the future, and you'll hit this DCHECK.


BUG=654804

Review-Url: https://codereview.chromium.org/2562963003
==========

to

==========
Fix DCHECK failure in extension_updater when scheduling first check

There's a DCHECK in ExtensionUpdater::ScheduleNextCheck that tries to
ensure we aren't scheduling the next check unreasonably soon (<= 1
second). But we serialize the "scheduled next check time" in prefs and
read that on next startup, and use it as long as it isn't in the past or
too far in the future, but if you get unlucky it can be < 1 second in
the future, and you'll hit this DCHECK.

BUG=654804

Committed: https://crrev.com/a94f63df7f0146e3532c22efb8e5468225e951c0
Cr-Commit-Position: refs/heads/master@{#438697}
==========

[commit-bot: I haz the power, 2016-12-15 01:21:06]

Patchset 2 (id:??) landed as
https://crrev.com/a94f63df7f0146e3532c22efb8e5468225e951c0
Cr-Commit-Position: refs/heads/master@{#438697}