Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2562913002: [Offline Pages] Minor fix for log messages in event logger. (Closed)

Created:
4 years ago by romax
Modified:
4 years ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Minor fix for log messages in event logger. Since the custom logger used by test harness already contains timestamp, we should remove the timestamp added in event logger for internal page. BUG=672692 Committed: https://crrev.com/825fa9c5a81c35e4040459b401ef679a171d49b4 Cr-Commit-Position: refs/heads/master@{#438304}

Patch Set 1 #

Patch Set 2 : fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M components/offline_pages/core/offline_event_logger.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/offline_pages/core/offline_event_logger_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
romax
PTAL, thanks!
4 years ago (2016-12-12 20:13:38 UTC) #6
Pete Williamson
lgtm
4 years ago (2016-12-13 17:51:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562913002/20001
4 years ago (2016-12-13 18:27:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 22:00:40 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-13 22:03:34 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/825fa9c5a81c35e4040459b401ef679a171d49b4
Cr-Commit-Position: refs/heads/master@{#438304}

Powered by Google App Engine
This is Rietveld 408576698