Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1776)

Issue 2562883002: Extract common code in BoundedFileNetLogObserverTest for reading NetLog. (Closed)

Created:
4 years ago by eroman
Modified:
4 years ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract common code in BoundedFileNetLogObserverTest for reading NetLog. Committed: https://crrev.com/fd237ef10c1472ee420157252fcec75f52c8f00c Cr-Commit-Position: refs/heads/master@{#437565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -143 lines) Patch
M net/log/bounded_file_net_log_observer_unittest.cc View 18 chunks +80 lines, -143 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
eroman
4 years ago (2016-12-09 00:51:10 UTC) #4
eroman
This seemed like a useful abstraction (which I re-used in https://codereview.chromium.org/2567473003/)
4 years ago (2016-12-09 00:52:03 UTC) #5
xunjieli
On 2016/12/09 00:52:03, eroman (slow) wrote: > This seemed like a useful abstraction (which I ...
4 years ago (2016-12-09 14:36:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562883002/1
4 years ago (2016-12-09 16:51:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 16:56:41 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-12 13:51:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd237ef10c1472ee420157252fcec75f52c8f00c
Cr-Commit-Position: refs/heads/master@{#437565}

Powered by Google App Engine
This is Rietveld 408576698