[PaymentApp] label field was changed to name field in PaymentAppOption.

[PaymentApp] label field was changed to name field in PaymentAppOption.

label field was changed to name field in PaymentAppOption.idl and PaymentAppManifest.idl
and also required keyword was added.

spec list:
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-manifest
https://github.com/w3c/webpayments-payment-apps-api/pull/70

BUG=661608
Committed: https://crrev.com/e86e8cd3274d2a531f8b77fe89e25aae4e7bf10b
Cr-Commit-Position: refs/heads/master@{#439192}

[Hwanseung Lee, 2016-12-09 00:12:10]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 00:12:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 00:24:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 00:24:54]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Hwanseung Lee, 2016-12-09 12:59:19]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 12:59:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 13:19:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 13:19:17]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Hwanseung Lee, 2016-12-10 01:41:06]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 01:41:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 03:20:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 03:20:44]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Hwanseung Lee, 2016-12-10 05:55:32]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 05:55:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2016-12-10 05:58:01]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 05:58:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 07:29:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 07:29:10]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2016-12-10 07:53:23]

Description was changed from

==========
[WIP] [PaymentApp] label -> name in PaymentAppOption.

BUG=

Signed-off-by: Hwanseung Lee <hs1217.lee@samsung.com>
==========

to

==========
[WIP] [PaymentApp] label -> name in PaymentAppOption.


spec list: 
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options
https://github.com/w3c/webpayments-payment-apps-api/pull/70

BUG=661608
==========

[Hwanseung Lee, 2016-12-10 07:57:59]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 07:58:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2016-12-10 08:11:41]

Description was changed from

==========
[WIP] [PaymentApp] label -> name in PaymentAppOption.


spec list: 
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options
https://github.com/w3c/webpayments-payment-apps-api/pull/70

BUG=661608
==========

to

==========
[PaymentApp] label field was changed to name field in PaymentAppOption.

label field was changed to name field in PaymentAppOption.
and also required keyword was added.

spec list: 
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options
https://github.com/w3c/webpayments-payment-apps-api/pull/70

BUG=661608
==========

[Hwanseung Lee, 2016-12-10 08:24:44]

hs1217.lee@samsung.com changed reviewers:
+ jinho.bang@samsung.com, rouslan@chromium.org

[commit-bot: I haz the power, 2016-12-10 09:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 09:40:33]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Hwanseung Lee, 2016-12-10 09:59:24]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 09:59:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 11:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 11:42:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Hwanseung Lee, 2016-12-10 13:22:08]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 13:22:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 15:12:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 15:12:50]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2016-12-10 15:42:10]

@rouslan, zino
PTAL, thank you.

[zino, 2016-12-11 18:55:01]

You should change PaymentAppManifest.idl as well :)

Maybe you can not use ImageObject for now. So the icons field should be kept
intact for the time being. But you can change other things. (e.g. id and
PaymentAppManifest.idl)

https://codereview.chromium.org/2562873002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentAppOption.idl (left):

https://codereview.chromium.org/2562873002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentAppOption.idl:10: DOMString
id;
This is also required.

[Hwanseung Lee, 2016-12-12 13:01:13]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 13:01:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2016-12-12 13:02:33]

Description was changed from

==========
[PaymentApp] label field was changed to name field in PaymentAppOption.

label field was changed to name field in PaymentAppOption.
and also required keyword was added.

spec list: 
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options
https://github.com/w3c/webpayments-payment-apps-api/pull/70

BUG=661608
==========

to

==========
[PaymentApp] label field was changed to name field in PaymentAppOption.

label field was changed to name field in PaymentAppOption.idl and
PaymentAppManifest.idl 
and also required keyword was added.

spec list: 
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-manifest
https://github.com/w3c/webpayments-payment-apps-api/pull/70

BUG=661608
==========

[commit-bot: I haz the power, 2016-12-12 13:03:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 13:03:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Hwanseung Lee, 2016-12-12 13:10:01]

@zino
i also changed label to name in paymentAppManifast.idl
i want to add "required" keyword at "sequence<PaymentAppOption> options" in this
CL.
but  i faced to crash when layout tests.
if you were fine, i will fix it next CL.

https://codereview.chromium.org/2562873002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentAppOption.idl (left):

https://codereview.chromium.org/2562873002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentAppOption.idl:10: DOMString
id;
On 2016/12/11 18:55:00, zino wrote:
> This is also required.

Done.

[Hwanseung Lee, 2016-12-12 13:19:49]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 13:19:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 14:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 14:10:05]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[zino, 2016-12-12 14:43:48]

On 2016/12/12 13:10:01, Hwanseung Lee wrote:
> @zino
> i also changed label to name in paymentAppManifast.idl
> i want to add "required" keyword at "sequence<PaymentAppOption> options" in
this
> CL.
> but  i faced to crash when layout tests.
> if you were fine, i will fix it next CL.

If you want to fix it, you should update parameter of setManifest() in the
layout test as follows.
...
setManifest({
        name: 'Payment App',
        icon: 'payment-app-icon',
        options: [{
          name: 'Visa ****',
          icon: 'payment-app-icon',
          id: 'payment-app-id',
          enabledMethods: ['visa']
        }]
      });

[Hwanseung Lee, 2016-12-12 15:09:07]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 15:09:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 15:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 15:10:55]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[please use gerrit instead, 2016-12-12 20:57:27]

https://codereview.chromium.org/2562873002/diff/120001/content/browser/paymen...
File content/browser/payments/payment_app.proto (right):

https://codereview.chromium.org/2562873002/diff/120001/content/browser/paymen...
content/browser/payments/payment_app.proto:12: required string name = 1;
Let's make all these fields optional.

These message describe how data is stored on disk. These formats should be
backward compatible. One rule of thumb to ensure backward compatibility is to
make all fields optional. It's OK to rename the field today, when no one has
used these messages out in the real world. However, if we want to rename a field
after this code has been shipped, we will need to do this instead:

message PaymentAppManifestProto {
  optional string label = 1; // deprecated in favor of |name|.
  optional string icon = 2;
  repeated PaymentAppOptionProto options = 3;
  optional name = 4;  // replaces |label|.
};

[Hwanseung Lee, 2016-12-13 15:06:32]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 15:06:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 16:49:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 16:49:58]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2016-12-14 06:11:16]

@zino
thank you for guide about parameter of setManifest().
when enabledMethods is not exist, i faced crash.
but enabledMethods is not required field in spec.
is it fine?
anyway, when set all field, it passed tests.

@rouslan
i just rename the field instead of to add new field.
next time, i will be careful. 
and i added optional keyword at all fields.

https://codereview.chromium.org/2562873002/diff/120001/content/browser/paymen...
File content/browser/payments/payment_app.proto (right):

https://codereview.chromium.org/2562873002/diff/120001/content/browser/paymen...
content/browser/payments/payment_app.proto:12: required string name = 1;
On 2016/12/12 20:57:27, rouslan wrote:
> Let's make all these fields optional.
> 
> These message describe how data is stored on disk. These formats should be
> backward compatible. One rule of thumb to ensure backward compatibility is to
> make all fields optional. It's OK to rename the field today, when no one has
> used these messages out in the real world. However, if we want to rename a
field
> after this code has been shipped, we will need to do this instead:
> 
> message PaymentAppManifestProto {
>   optional string label = 1; // deprecated in favor of |name|.
>   optional string icon = 2;
>   repeated PaymentAppOptionProto options = 3;
>   optional name = 4;  // replaces |label|.
> };

Done.

[zino, 2016-12-14 14:10:04]

On 2016/12/14 06:11:16, Hwanseung Lee wrote:
> @zino
> thank you for guide about parameter of setManifest().
> when enabledMethods is not exist, i faced crash.
> but enabledMethods is not required field in spec.
> is it fine?
> anyway, when set all field, it passed tests.
> 

lgtm

I don't mind if you fix it in follow-up CL.
You will be able to fix it adding hasEnabledMethods() check in
PaymentAppManager.cpp:31
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/paymen...

[please use gerrit instead, 2016-12-14 15:37:15]

lgtm

[Hwanseung Lee, 2016-12-14 21:33:12]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-12-14 21:33:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 21:44:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Hwanseung Lee, 2016-12-14 23:42:47]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 23:43:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2016-12-14 23:46:46]

hs1217.lee@samsung.com changed reviewers:
+ rsesek@chromium.org

[Hwanseung Lee, 2016-12-14 23:48:30]

@rsesek
PTAL, could you review components/payments/payment_app.mojom file?

[commit-bot: I haz the power, 2016-12-15 00:18:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:18:15]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Robert Sesek, 2016-12-15 17:39:00]

mojom lgtm

[Hwanseung Lee, 2016-12-15 21:32:08]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-12-15 21:33:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 22:03:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 22:03:49]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Hwanseung Lee, 2016-12-16 14:35:16]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 14:35:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 14:39:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 14:39:16]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hwanseung Lee, 2016-12-16 15:30:30]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 15:30:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 15:34:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 15:34:11]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hwanseung Lee, 2016-12-16 15:36:02]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 15:36:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 15:47:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 15:47:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Hwanseung Lee, 2016-12-16 15:48:01]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 15:48:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2016-12-16 15:52:01]

hs1217.lee@samsung.com changed reviewers:
+ dfalcantara@chromium.org

[Hwanseung Lee, 2016-12-16 15:52:02]

@dfalcantara
PTAL, could you review
chrome/browser/android/payments/service_worker_payment_app_bridge.cc files?

[commit-bot: I haz the power, 2016-12-16 17:15:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 17:15:40]

Dry run: This issue passed the CQ dry run.

[gone, 2016-12-16 18:01:34]

That file LGTM

[Hwanseung Lee, 2016-12-16 21:19:28]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2016-12-16 21:19:28]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
rouslan@chromium.org, jinho.bang@samsung.com
Link to the patchset: https://codereview.chromium.org/2562873002/#ps200001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-16 21:21:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 21:28:29]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1481923168051890,
"parent_rev": "324b8f1efc84cd954f8e18a206aa612a6eb206d1", "commit_rev":
"0f0da2909ed681949f575f6dfd4b8f710509e606"}

[commit-bot: I haz the power, 2016-12-16 21:28:58]

Description was changed from

==========
[PaymentApp] label field was changed to name field in PaymentAppOption.

label field was changed to name field in PaymentAppOption.idl and
PaymentAppManifest.idl 
and also required keyword was added.

spec list: 
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-manifest
https://github.com/w3c/webpayments-payment-apps-api/pull/70

BUG=661608
==========

to

==========
[PaymentApp] label field was changed to name field in PaymentAppOption.

label field was changed to name field in PaymentAppOption.idl and
PaymentAppManifest.idl 
and also required keyword was added.

spec list: 
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-manifest
https://github.com/w3c/webpayments-payment-apps-api/pull/70

BUG=661608

Review-Url: https://codereview.chromium.org/2562873002
==========

[commit-bot: I haz the power, 2016-12-16 21:28:59]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-12-16 21:32:05]

Description was changed from

==========
[PaymentApp] label field was changed to name field in PaymentAppOption.

label field was changed to name field in PaymentAppOption.idl and
PaymentAppManifest.idl 
and also required keyword was added.

spec list: 
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-manifest
https://github.com/w3c/webpayments-payment-apps-api/pull/70

BUG=661608

Review-Url: https://codereview.chromium.org/2562873002
==========

to

==========
[PaymentApp] label field was changed to name field in PaymentAppOption.

label field was changed to name field in PaymentAppOption.idl and
PaymentAppManifest.idl
and also required keyword was added.

spec list:
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options
https://w3c.github.io/webpayments-payment-apps-api/#payment-app-manifest
https://github.com/w3c/webpayments-payment-apps-api/pull/70

BUG=661608

Committed: https://crrev.com/e86e8cd3274d2a531f8b77fe89e25aae4e7bf10b
Cr-Commit-Position: refs/heads/master@{#439192}
==========

[commit-bot: I haz the power, 2016-12-16 21:32:06]

Patchset 11 (id:??) landed as
https://crrev.com/e86e8cd3274d2a531f8b77fe89e25aae4e7bf10b
Cr-Commit-Position: refs/heads/master@{#439192}