Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2562703003: Make AlgorithmForInputNode use original constraint space (Closed)

Created:
4 years ago by atotic
Modified:
4 years ago
Reviewers:
ikilpatrick
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Primary fix: Make AlgorithmForInputNode use container constraint space insted of child space. Secondary: This change causes constraint space to not be const Also, minor bug fixes by Ian to make tests pass. BUG=635619 Committed: https://crrev.com/daaaf8661aa98f3f3eaa69a30816c2fae4f32704 Cr-Commit-Position: refs/heads/master@{#437683}

Patch Set 1 #

Patch Set 2 : Make AlgorithmForInputNode use container constraint space #

Messages

Total messages: 14 (9 generated)
atotic
ptal
4 years ago (2016-12-09 21:06:08 UTC) #5
ikilpatrick
lgtm
4 years ago (2016-12-09 21:09:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562703003/60001
4 years ago (2016-12-09 21:11:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years ago (2016-12-09 23:20:47 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 14:58:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/daaaf8661aa98f3f3eaa69a30816c2fae4f32704
Cr-Commit-Position: refs/heads/master@{#437683}

Powered by Google App Engine
This is Rietveld 408576698